Re: rpki-client: reject bad URLs in cert files

2020-12-02 Thread Robert Scheck
On Wed, 02 Dec 2020, Claudio Jeker wrote: > Be stricter in what we accept as URL. Nobody should use silly encodings > like UTF-8 or other crap in the embedded URLs. I also consider any kind of > space as a failure (use %20 instead if that is really needed). Really? So ȓþʞí.idna2008.example.net is

Re: rpki-client: reject bad URLs in cert files

2020-12-02 Thread Todd C . Miller
On Wed, 02 Dec 2020 17:18:49 +0100, Theo Buehler wrote: > Should this also check isascii() to ensure that this works as intended > in the -portable version? The ENVIRONMENT section of the isalnum() and > ispunct() manuals suggests that the characters satisfying this could be > locale-dependent on

Re: rpki-client: reject bad URLs in cert files

2020-12-02 Thread Theo Buehler
On Wed, Dec 02, 2020 at 03:17:43PM +0100, Claudio Jeker wrote: > Be stricter in what we accept as URL. Nobody should use silly encodings > like UTF-8 or other crap in the embedded URLs. I also consider any kind of > space as a failure (use %20 instead if that is really needed). > > This makes late

Re: rpki-client: reject bad URLs in cert files

2020-12-02 Thread Todd C . Miller
On Wed, 02 Dec 2020 15:17:43 +0100, Claudio Jeker wrote: > Be stricter in what we accept as URL. Nobody should use silly encodings > like UTF-8 or other crap in the embedded URLs. I also consider any kind of > space as a failure (use %20 instead if that is really needed). > > This makes later hand

rpki-client: reject bad URLs in cert files

2020-12-02 Thread Claudio Jeker
Be stricter in what we accept as URL. Nobody should use silly encodings like UTF-8 or other crap in the embedded URLs. I also consider any kind of space as a failure (use %20 instead if that is really needed). This makes later handling of URLs a lot safer (e.g. rpki-client prints part of URLs in l