Re: rpki-client X509_free XXX fix

2021-11-04 Thread Sebastian Benoit
Claudio Jeker(cje...@diehard.n-r-g.com) on 2021.11.04 18:31:54 +0100: > There is this bit in parser.c > X509_free(x509); // needed? XXX > > As tb@ properly noted this X509_free() is needed because the cert_parse() > returns an up referenced x509 pointer back. > > I moved the X509_free() so

Re: rpki-client X509_free XXX fix

2021-11-04 Thread Theo Buehler
On Thu, Nov 04, 2021 at 06:31:54PM +0100, Claudio Jeker wrote: > There is this bit in parser.c > X509_free(x509); // needed? XXX > > As tb@ properly noted this X509_free() is needed because the cert_parse() > returns an up referenced x509 pointer back. > > I moved the X509_free() so the

rpki-client X509_free XXX fix

2021-11-04 Thread Claudio Jeker
There is this bit in parser.c X509_free(x509); // needed? XXX As tb@ properly noted this X509_free() is needed because the cert_parse() returns an up referenced x509 pointer back. I moved the X509_free() so the error cases become simpler and we no longer leak a reference on success. At