Re: rpki-client valid_x509() followup

2022-01-18 Thread Claudio Jeker
On Tue, Jan 18, 2022 at 07:15:54PM +0100, Theo Buehler wrote: > > I will commit this version in a bit (once rpki-client finished its run). > > I like this approach a lot better. ok > > One small comment below. > > > -- > > :wq Claudio > > > > Index: parser.c > > ===

Re: rpki-client valid_x509() followup

2022-01-18 Thread Theo Buehler
> I will commit this version in a bit (once rpki-client finished its run). I like this approach a lot better. ok One small comment below. > -- > :wq Claudio > > Index: parser.c > === > RCS file: /cvs/src/usr.sbin/rpki-client/parse

Re: rpki-client valid_x509() followup

2022-01-18 Thread Claudio Jeker
On Tue, Jan 18, 2022 at 06:46:35PM +0100, Theo Buehler wrote: > On Tue, Jan 18, 2022 at 06:38:46PM +0100, Claudio Jeker wrote: > > This is a follow up to the valid_x509() commit form earlier today. > > tb@ suggested that the crl check should be grouped together. > > After some thought I decided to

Re: rpki-client valid_x509() followup

2022-01-18 Thread Theo Buehler
On Tue, Jan 18, 2022 at 06:38:46PM +0100, Claudio Jeker wrote: > This is a follow up to the valid_x509() commit form earlier today. > tb@ suggested that the crl check should be grouped together. > After some thought I decided to do this all different. > First of all introduce a checkcrl flag which

rpki-client valid_x509() followup

2022-01-18 Thread Claudio Jeker
This is a follow up to the valid_x509() commit form earlier today. tb@ suggested that the crl check should be grouped together. After some thought I decided to do this all different. First of all introduce a checkcrl flag which turns on X509_V_FLAG_CRL_CHECK. This prevents code that expects a CRL t