Re: rsync fix symlink discovery

2021-07-06 Thread Claudio Jeker
On Mon, Jul 05, 2021 at 08:11:12PM -0900, Philip Guenther wrote: > Based on the fts_open(3) manpage and other base source usage, shouldn't > this use fts_accpath instead of fts_name? Yes this should use fts_accpath. I knew there was something different than fts_name. I just missed it when I read

Re: rsync fix symlink discovery

2021-07-05 Thread Philip Guenther
Based on the fts_open(3) manpage and other base source usage, shouldn't this use fts_accpath instead of fts_name? The use of fts_statp in this code seems a bit loose vs ftp_info: instead of using S_ISLNK() on fts_statp I would expect this code to check for fts_info == FTS_SL: according the

rsync fix symlink discovery

2021-07-02 Thread Claudio Jeker
Hit this today while doing some tests. symlink_read() needs to use just the filename and not the full path because fts_read(3) does chdir internally. Without this I got: openrsync: error: ./obj/openrsync.1: readlink: No such file or directory openrsync: error: symlink_read openrsync: error: