Re: sdmmc(4) off-by-one on boundary check

2021-03-25 Thread Marcus Glocker
On Wed, Mar 24, 2021 at 09:23:22PM +0100, Mark Kettenis wrote: > > Date: Wed, 24 Mar 2021 20:58:48 +0100 > > From: Marcus Glocker > > > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > > > Mark Kettenis wrote: > > > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Wed, Mar 24, 2021 at 02:05:27PM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > > > Mark Kettenis wrote: > > > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Mark Kettenis
> Date: Wed, 24 Mar 2021 20:58:48 +0100 > From: Marcus Glocker > > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > Mark Kettenis wrote: > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > === > > > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Theo de Raadt
Marcus Glocker wrote: > On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > > > Mark Kettenis wrote: > > > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > > === > > > > > RCS file:

Re: sdmmc(4) off-by-one on boundary check

2021-03-24 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 09:52:42AM -0600, Theo de Raadt wrote: > Mark Kettenis wrote: > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > > === > > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > > > retrieving revision 1.59

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
Mark Kettenis wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > > === > > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > > retrieving revision 1.59 > > > diff -u -p -u -p -r1.59 sdmmc_scsi.c > > > ---

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Mark Kettenis
> From: "Theo de Raadt" > Date: Tue, 23 Mar 2021 08:29:06 -0600 > > Marcus Glocker wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > === > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > retrieving revision 1.59 > > diff -u

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
That is what I envisioned. It is just an off-by-one on the bounds check. Marcus Glocker wrote: > On Tue, Mar 23, 2021 at 08:29:06AM -0600, Theo de Raadt wrote: > > > Marcus Glocker wrote: > > > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > >

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
On Tue, Mar 23, 2021 at 08:29:06AM -0600, Theo de Raadt wrote: > Marcus Glocker wrote: > > > Index: sys/dev/sdmmc/sdmmc_scsi.c > > === > > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > > retrieving revision 1.59 > > diff -u -p

Re: sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Theo de Raadt
Marcus Glocker wrote: > Index: sys/dev/sdmmc/sdmmc_scsi.c > === > RCS file: /cvs/src/sys/dev/sdmmc/sdmmc_scsi.c,v > retrieving revision 1.59 > diff -u -p -u -p -r1.59 sdmmc_scsi.c > --- sys/dev/sdmmc/sdmmc_scsi.c15 Oct 2020

sdmmc(4) off-by-one on boundary check

2021-03-23 Thread Marcus Glocker
I recently got a Raspberry Pi 3 Model B Plus (Rev 1.3). After installing current the first thing during boot which I get is: ... starting network reordering libraries: done. starting early daemons: syslogd pflogd ntpd. starting RPC daemons:. savecore: no core dump bcmsdhost0: transfer timeout!