Re: sndiod: Move controls out of the device structure, please test & review

2021-01-30 Thread Edd Barrett
On Fri, Jan 29, 2021 at 04:16:44PM +0100, Alexandre Ratchov wrote: > Thanks for the feedback, new diff below. It fixes a server crash when > a client issues an invalid request. I retested the crash scenario, and can confirm that it is fixed. No other problems to report! -- Best Regards Edd

Re: sndiod: Move controls out of the device structure, please test & review

2021-01-29 Thread Alexandre Ratchov
On Fri, Jan 29, 2021 at 12:42:37PM +0100, Alexandre Ratchov wrote: > Moving to a global server-wide controls list is necessary to expose > controls that are not associated to a particular device (ex. a device > selector). > > The current hack to use the device-side sioctl_desc->addr variable as >

sndiod: Move controls out of the device structure, please test & review

2021-01-29 Thread Alexandre Ratchov
Moving to a global server-wide controls list is necessary to expose controls that are not associated to a particular device (ex. a device selector). The current hack to use the device-side sioctl_desc->addr variable as client-side key can't work anymore. So, we use a unique dynamically allocated