Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Reyk Floeter
On Fri, May 10, 2013 at 04:53:18PM +0200, Mike Belopuhov wrote: > > if (tr->tr_ac.ac_if.if_mtu != ifp->if_mtu) seems wrong. what about people > > who want to use trunk between two totally different interfaces for failover? > > > > i think the trunk mtu should simply be the lowest common of the grou

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Reyk Floeter
Hi, the diff is needed - I was running into it quite recently when I was trying some QinQ/svlan configurations on trunk. Comments below, otherwise OK reyk On Fri, May 10, 2013 at 02:11:28PM +0100, Stuart Henderson wrote: > Index: if_trunk.c >

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Stuart Henderson
On 2013/05/10 16:53, Mike Belopuhov wrote: > On 10 May 2013 16:43, Chris Cappuccio wrote: > > Stuart Henderson [st...@openbsd.org] wrote: > >> On 2013/02/22 12:30, Stuart Henderson wrote: > >> > I thought we already had something for this after the misc@ thread > >> > a few months ago, but clearly

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Mike Belopuhov
On 10 May 2013 16:43, Chris Cappuccio wrote: > Stuart Henderson [st...@openbsd.org] wrote: >> On 2013/02/22 12:30, Stuart Henderson wrote: >> > I thought we already had something for this after the misc@ thread >> > a few months ago, but clearly not. >> > >> > Adapted from FreeBSD if_lagg.c r17166

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Chris Cappuccio
Stuart Henderson [st...@openbsd.org] wrote: > On 2013/02/22 12:30, Stuart Henderson wrote: > > I thought we already had something for this after the misc@ thread > > a few months ago, but clearly not. > > > > Adapted from FreeBSD if_lagg.c r171661 (which includes capability > > setting which we al

Re: trunk(4) take MTU from first member port.

2013-05-10 Thread Stuart Henderson
On 2013/02/22 12:30, Stuart Henderson wrote: > I thought we already had something for this after the misc@ thread > a few months ago, but clearly not. > > Adapted from FreeBSD if_lagg.c r171661 (which includes capability > setting which we already do). > http://svnweb.freebsd.org/base/head/sys/net

Re: trunk(4) take MTU from first member port.

2013-02-22 Thread Janne Johansson
Worked fine on my dual-ix(4) setup. In loadbalance mode with 9k frames it gave me more Gbits than with a single ix(4) connection, even if I didn't go ape on all possible combinations of mtu, trunkprotos and whatnot. Quick test with tcpbench on Dell 320s without pf and 9k mtu and two ix(4) showed 6.

trunk(4) take MTU from first member port.

2013-02-22 Thread Stuart Henderson
I thought we already had something for this after the misc@ thread a few months ago, but clearly not. Adapted from FreeBSD if_lagg.c r171661 (which includes capability setting which we already do). http://svnweb.freebsd.org/base/head/sys/net/if_lagg.c?r1=171603&r2=171661 Index: if_trunk.c ===