Re: tunefs(8): Fix handling of device names

2015-08-29 Thread Steven McDonald
On Sat, 29 Aug 2015 21:48:34 +1000 Steven McDonald wrote: > Index: lib/libutil/opendev.c > === > RCS file: /cvs/src/lib/libutil/opendev.c,v > retrieving revision 1.15 > diff -u -p -r1.15 opendev.c > --- lib/libutil/opendev.c 30 J

Re: tunefs(8): Fix handling of device names

2015-08-29 Thread Steven McDonald
Same diff, corrected formatting. Sorry for the noise. Index: lib/libutil/opendev.3 === RCS file: /cvs/src/lib/libutil/opendev.3,v retrieving revision 1.22 diff -u -p -r1.22 opendev.3 --- lib/libutil/opendev.3 15 Jan 2015 19:06:3

Re: tunefs(8): Fix handling of device names

2015-08-24 Thread Steven McDonald
On Sun, 23 Aug 2015 19:45:17 +1000 Steven McDonald wrote: > fd = opendev(name, flags, 0, devicep); > if (fd == -1 && errno == ENOENT) > - devicep = &name; > + *devicep = name; I'm actually wondering if opendev(3) itself should set realpath to path in t

Re: tunefs(8): Fix handling of device names

2015-08-23 Thread Steven McDonald
On Sun, 23 Aug 2015 19:21:42 +1000 Steven McDonald wrote: > Also, section 6.9.1 clause 9 of C99[0] says that "each parameter has > automatic storage duration", so I think it's not safe to rely on a > function parameter still being a valid object outside of openpartition > (please correct me if I'

tunefs(8): Fix handling of device names

2015-08-23 Thread Steven McDonald
The openpartition function in tunefs(8) will currently set devicep, a char** passed in from main, to the path it attempted to opendev(3). This doesn't actually work as intended; it should be setting the value devicep points to instead of devicep itself. Also, section 6.9.1 clause 9 of C99[0] says