Re: tunnels, ecn, and ipv4 header checksums

2018-11-14 Thread Claudio Jeker
On Wed, Nov 14, 2018 at 08:16:33PM +1000, David Gwynne wrote: > On Wed, Nov 14, 2018 at 11:49:02AM +1000, David Gwynne wrote: > > while looking at outgoing ttl processing and rfc 6040, i noted that gif > > and gre patched a packets ttl, but didn't update the checksum on the > > packet. > > > > i

Re: tunnels, ecn, and ipv4 header checksums

2018-11-14 Thread David Gwynne
On Wed, Nov 14, 2018 at 11:49:02AM +1000, David Gwynne wrote: > while looking at outgoing ttl processing and rfc 6040, i noted that gif > and gre patched a packets ttl, but didn't update the checksum on the > packet. > > i think there's two issues here. firstly, we need to update the checksum >

tunnels, ecn, and ipv4 header checksums

2018-11-13 Thread David Gwynne
while looking at outgoing ttl processing and rfc 6040, i noted that gif and gre patched a packets ttl, but didn't update the checksum on the packet. i think there's two issues here. firstly, we need to update the checksum when the packet is patched, but only for v4, and secondly, we should clear