Re: uvm combine clearbits

2013-03-26 Thread Bob Beck
On Tue, Mar 26, 2013 at 10:55 AM, Miod Vallat wrote: >> > uvm_pagefree calls atomic_clearbits_int too many times. >> >> Is there some sort of evidence that this is a problem - performace or >> stability wise? > > Platforms which can't do ll/sc style atomic operations usually wrap > these operation

Re: uvm combine clearbits

2013-03-26 Thread Theo de Raadt
> > > uvm_pagefree calls atomic_clearbits_int too many times. > > > > Is there some sort of evidence that this is a problem - performace or > > stability wise? > > Platforms which can't do ll/sc style atomic operations usually wrap > these operations within splhigh()/splx() calls, which are a tad

Re: uvm combine clearbits

2013-03-26 Thread Miod Vallat
> > uvm_pagefree calls atomic_clearbits_int too many times. > > Is there some sort of evidence that this is a problem - performace or > stability wise? Platforms which can't do ll/sc style atomic operations usually wrap these operations within splhigh()/splx() calls, which are a tad expensive. I

Re: uvm combine clearbits

2013-03-26 Thread Bob Beck
On Tue, Mar 26, 2013 at 1:51 AM, Ted Unangst wrote: > uvm_pagefree calls atomic_clearbits_int too many times. Is there some sort of evidence that this is a problem - performace or stability wise? >Just > accumulate the flags we need to zap, then do it once. I get what you're trying to do, but

uvm combine clearbits

2013-03-26 Thread Ted Unangst
uvm_pagefree calls atomic_clearbits_int too many times. Just accumulate the flags we need to zap, then do it once. Index: uvm_page.c === RCS file: /cvs/src/sys/uvm/uvm_page.c,v retrieving revision 1.122 diff -u -p -r1.122 uvm_page.c -