On Thu, Jun 23, 2016 at 02:41:53PM +0200, Mark Kettenis wrote:
> > Date: Thu, 23 Jun 2016 13:09:28 +0200
> > From: Alexander Bluhm
> >
> > On Wed, Jun 22, 2016 at 10:54:27PM +1000, David Gwynne wrote:
> > > secondly, allocating more than 4g at a time to socket buffers is
> > > generally a waste o
On Tue, Jul 05, 2016 at 07:22:27AM -0600, Bob Beck wrote:
> Makes sense to me. Others?
>
>
> On Tue, Jul 5, 2016 at 4:08 AM, Simon Mages
> wrote:
> > At the moment the buffersize will be set to the default even if the
> > current value
> > is smaller.
> >
> > The following diff fixes this prob
On Tue, Jul 12, 2016 at 11:28:47AM +0200, Martin Pieuchot wrote:
> By default we have a route to reject compatible addresses:
>
> ::/96 ::1UGRS 0 0 32768 8 lo0
>
> But the corresponding check in ip6_input() is still commented because it
> is "stronge
On Tue, Jul 12, 2016 at 11:46:43AM +0200, Martin Pieuchot wrote:
> On 12/07/16(Tue) 11:33, Claudio Jeker wrote:
> > On Tue, Jul 12, 2016 at 11:28:47AM +0200, Martin Pieuchot wrote:
> > > By default we have a route to reject compatible addresses:
> > >
> >
On Mon, Jul 18, 2016 at 03:01:48PM +0200, Martin Pieuchot wrote:
> I use a vlan(4) on top of a tap(4). Since the rewrite that made vlan(4)
> MP-safe I got errors during boot because my tap0 is not UP when I try
> to bring my vlan up.
>
> Now that tap(4) has been separated from tun(4) is there any
oidtlsc_modify(struct relayd *, u_int, const void *, size_t,
+ void *, size_t, long);
+voidtlsc_create_ticket(struct tls_ticket_ctx *);
/* relayd.c */
struct host*host_find(struct relayd *, objid_t);
Index: tlsc.c
=
On Tue, Jul 19, 2016 at 10:40:14PM +0200, Alexander Bluhm wrote:
> On Tue, Jul 19, 2016 at 09:19:25PM +0100, Jason McIntyre wrote:
> > On Tue, Jul 19, 2016 at 10:09:47PM +0200, Alexander Bluhm wrote:
> > > On Tue, Jul 19, 2016 at 08:55:58PM +0200, Joerg Jung wrote:
> > > > Please, also document it,
On Tue, Jul 19, 2016 at 11:00:04PM +0200, Alexander Bluhm wrote:
> Hi,
>
> When looking at the error paths in tcp_output() I have found these
> returns that look like mbuf leaks.
>
> ok?
Indeed. OK claudio@
Looking at tcp_signature() I actually think it can not fail but better
safe than sorry.
For testing I want to abuse tcpbench to work over AF_UNIX sockets.
This diff does exactly that with minimal extras. Especially the unix
socket is not removed from the filesystem when closed. I don't want to
add pledge cpath to tcpbench just for that.
--
:wq Claudio
Index: tcpbench.1
On Wed, Jul 20, 2016 at 04:09:48PM +0200, Claudio Jeker wrote:
> For testing I want to abuse tcpbench to work over AF_UNIX sockets.
> This diff does exactly that with minimal extras. Especially the unix
> socket is not removed from the filesystem when closed. I don't want to
> ad
On Fri, Jul 22, 2016 at 11:26:57AM +0200, Mark Kettenis wrote:
> > From: Tim Newsham
> > Date: Fri, 22 Jul 2016 08:32:04 +
> >
> > Here's a new one we just found:
> >
> > /*
> > * sysctl_tmpfs_panic.c
> > *Demonstrate a panic in UFS through the getdents system call.
> > *
> > * gcc -
On Sat, Jul 30, 2016 at 10:03:33PM +0200, Mark Kettenis wrote:
> Removes a couple of lines of code from the driver.
>
> ok?
This is the right use of m_devget. OK claudio@
PS: realized that the manpage for m_devget still has the old prototype
with the ifp in it...
--
:wq Claudio
>
> Index: i
On Tue, Aug 02, 2016 at 01:48:11PM +0200, Jeremie Courreges-Anglas wrote:
> Nima GHOTBI writes:
>
> > please try the attachments
> >
> > On Sun, Jul 31, 2016 at 7:27 PM, Jeremie Courreges-Anglas
> > wrote:
> >
> >> Nima GHOTBI writes:
> >>
> >> > Hi everyone
> >> >
> >> > In one of our projects
On Tue, Jul 19, 2016 at 03:32:13PM +0200, Claudio Jeker wrote:
> At the moment relayd's TLS session caching is a bit busted because
> the multiple relay processes do not share state.
> The following diff adds SSL session caching and sharing of the TLS ticket
> secrets. Which this
On Fri, Aug 12, 2016 at 04:38:45PM +1000, David Gwynne wrote:
>
> > On 1 Aug 2016, at 21:07, Simon Mages wrote:
> >
> > I sent this message to dlg@ directly to discuss my modification of his
> > diff to make the
> > bigger mbuf clusters work. i got no response so far, thats why i
> > decided to
This diff refactors the uio to mbuf code to make use of bigger buffers (up
to 64k) and also switches the MCLGET to use M_WAIT like the MGET calls in
the same function. I see no point in not waiting for a cluster and instead
chain lots of mbufs together as a consequence.
This makes in my opinion th
On Mon, Aug 15, 2016 at 08:41:52AM +0200, Martin Pieuchot wrote:
> On 08/08/16(Mon) 11:42, Martin Pieuchot wrote:
> > On the train back from n2k16 I found the real cause of the hang reported
> > by Dimitris Papastamos [0] and exposed by our recent
> > changes to the routing table.
> >
> > When an
On Mon, Aug 15, 2016 at 08:42:06AM +0200, Martin Pieuchot wrote:
> On 08/08/16(Mon) 11:48, Martin Pieuchot wrote:
> > The rtable_walk() & prio bug I just sent a fix for should theoretically
> > not cause any trouble. Sadly it is piled on top of another bug for
> > which a fix is attached.
> >
> >
On Wed, Aug 17, 2016 at 02:29:49PM +0200, Alexander Bluhm wrote:
> On Wed, Aug 17, 2016 at 10:18:26PM +1000, David Gwynne wrote:
> > the reason is that pools now keep track of things that are sleeping
> > for memory and will give them an item BEFORE waking them up.
> > previously i believe they wer
On Wed, Aug 17, 2016 at 10:39:51AM +0100, Stuart Henderson wrote:
> On 2016/08/17 10:11, Peter Hessler wrote:
> > It sure would be nice if we could see the PID of the process that added
> > routes. Heck, route(8) even tries to print them already.
> >
> > Add the fields to the appropriate struct,
On Thu, Aug 18, 2016 at 12:49:07AM +0200, Alexander Bluhm wrote:
> On Wed, Aug 17, 2016 at 09:21:21PM +0200, Claudio Jeker wrote:
> > On Wed, Aug 17, 2016 at 02:29:49PM +0200, Alexander Bluhm wrote:
> > > As I understand, we are hitting the global mbuf cluster limit. I
>
On Sun, Aug 21, 2016 at 02:25:15PM -0400, Ted Unangst wrote:
> Andreas Bartelt wrote:
> > Since the use of TLS session tickets potentially interferes with forward
> > secrecy on a per-session basis, I'd personally prefer an opt-in in
> > libtls as well as in httpd with regard to its usage. Howeve
On Mon, Aug 22, 2016 at 12:58:31PM +0200, Martin Pieuchot wrote:
> I'd like to implement a route caching mechanism that works with PF state
> keys and always pick newest more specific route when available.
>
> In order to do so I need to get rid of the 'struct route'. The problem
> of the 'struct
On Mon, Aug 22, 2016 at 01:21:47PM +0200, Martin Pieuchot wrote:
> When it comes to reference counting in the receiving path, route entries
> act as proxy for interface addresses. In other words you CANNOT
> dereference ``rt->rt_ifa'' after calling rtfree(9).
>
> Diff below fixes that in icmp_ref
On Tue, Aug 30, 2016 at 10:48:53AM +0200, Mike Belopuhov wrote:
> On Tue, Aug 30, 2016 at 08:31 +0200, Mark Kettenis wrote:
> > > Date: Tue, 30 Aug 2016 07:48:09 +0200
> > > From: Mike Belopuhov
> > >
> > > On Tue, Aug 30, 2016 at 09:58 +1000, David Gwynne wrote:
> > > > On Mon, Aug 29, 2016 at 0
On Tue, Aug 30, 2016 at 07:36:09PM +1000, David Gwynne wrote:
> ok?
Needs to be OK or we have a serious issue.
> Index: radix.c
> ===
> RCS file: /cvs/src/sys/net/radix.c,v
> retrieving revision 1.52
> diff -u -p -r1.52 radix.c
> --
01
#define RELAYD_OPT_VERBOSE 0x01
@@ -1239,6 +1261,11 @@ int ssl_ctx_fake_private_key(SSL_CTX *,
/* ca.c */
pid_t ca(struct privsep *, struct privsep_proc *);
voidca_engine_init(struct relayd *);
+
+/* tlsc.c */
+pid_t tlsc(struct privsep *, struct privsep_proc *
On Tue, Aug 30, 2016 at 02:44:17PM +0200, Reyk Floeter wrote:
> On Tue, Aug 30, 2016 at 01:22:49PM +0200, Claudio Jeker wrote:
> > Here is the latest version of the ticket and tls session cache support.
> > Tickets can be disabled and also the session timeout is configurable.
&
On Wed, Aug 31, 2016 at 02:23:00PM +0200, Stefan Sperling wrote:
> 'instance' is the name of an ifconfig subcommand related to ifmedia
> so the name of the setinstance() function is slightly confusing.
OK
> Index: ifconfig.c
> ===
>
On Tue, Aug 30, 2016 at 03:51:04PM +0200, Claudio Jeker wrote:
> On Tue, Aug 30, 2016 at 02:44:17PM +0200, Reyk Floeter wrote:
> > On Tue, Aug 30, 2016 at 01:22:49PM +0200, Claudio Jeker wrote:
> > > Here is the latest version of the ticket and tls session cache support.
&g
I really like this. It will allow us to move forward. While I was for a
long time holding the opinion that static routes should not disapear from
the routing table because the interface address changes I came to the
conclusion that this is causing more harm and so it is better to remove
all routes
On Sun, Sep 04, 2016 at 05:43:20PM +0200, Martin Pieuchot wrote:
> Thanks to awolk@ hacking on USB wireless we found a lot of new races in
> the network stack.
>
> Passing and ``ifp'' pointer to a task is *not* safe. If the task
> sleeps, then another thread my start executing if_detach() freeing
On Thu, Sep 08, 2016 at 11:54:01AM +1000, David Gwynne wrote:
> it uses the time to rate limit the sending of assertion messages.
>
> there are two reasons for this change.
>
> firstly, using uptime instead of wall time means the intervals will
> be measured against a a monotonic clock that isnt
On Mon, Sep 12, 2016 at 11:15:21AM +0200, Martin Pieuchot wrote:
> soaccept() is always called at IPL_SOFTNET, so assert it instead of
> raising the SPL level recursively. This is not a problem currently
> but will be one as soon as we use a non-recursive rwlock.
>
> ok?
OK claudio (I bet there
On Mon, Sep 12, 2016 at 01:34:25PM +0200, Martin Pieuchot wrote:
> bridge(4) no longer accept gif(4) interfaces, so kill no dead code, ok?
Sure! Long live etherip(4).
> Index: net/if_gif.c
> ===
> RCS file: /cvs/src/sys/net/if_gif.c
On Wed, Sep 14, 2016 at 02:46:27PM +1000, David Gwynne wrote:
> Yes, this is just a conservative first step to that.
OK on the first step. I hope more follow :)
> On 14 Sep 2016 12:00 p.m., "Todd C. Miller"
> wrote:
>
> > Looks OK. Do you intend to change m_copym0 to m_copym and remove
> > th
On Wed, Sep 21, 2016 at 08:32:01AM +0530, S.Gopinath SundaraRajan wrote:
> Hi,
>
> I just started using OpenBSD's ospfd.
>
> 1. I would like to have a direct Ethernet link
> between OpenBSD box and Cisco/Juniper router.
>
> I would like to specify the link type as point to point.
>
> Which conf
On Mon, Sep 26, 2016 at 11:14:51PM +0200, Sebastian Benoit wrote:
> If we do this, i think the as-path loop detection needs to also check for
> these additional ASes.
>
> Otherwise we create a nice loop when we get our own route
> from an ebgp neighbor with this as in the path.
>
I know cisco ha
Same same but one line of code less and no more goto.
OK?
--
:wq Claudio
Index: net/raw_usrreq.c
===
RCS file: /cvs/src/sys/net/raw_usrreq.c,v
retrieving revision 1.24
diff -u -p -r1.24 raw_usrreq.c
--- net/raw_usrreq.c5 Sep 201
I want to make route_output and route_input and a few other things in
rtsock.c less hostile so here is a refactoring of the code.
Main goal is to make it clearer how the return packet is generated.
--
:wq Claudio
Index: net/rtsock.c
===
So rn_refines() is a function from the deep underbelly of radix code.
In my opinion if.c should not use this function especially now that we use
art for routing table lookups. Instead I implemented a simple
ifa_netmask_cmp() function that does what the code expects and compares
the two netmasks. It
It is time to put the nasty comment from rl(4) into em(4) and ix(4).
Everybody knew how bad realtek was but thinks Intel nics are good. The
truth is that modern Intel nic are as bad as the cheepest and crapiest
10/100 Mbps Ethernet chips from the last millenium.
--
:wq Claudio
On Fri, Oct 14, 20
On Fri, Oct 14, 2016 at 10:44:33AM +0200, Peter Hessler wrote:
> While working on Large Communities, I realized that I would really like
> to easily see and know when I am receiving "unknown" attributes.
>
> Patch for tcpdump is easy, if it doesn't have a decoder, just print the
> type and length.
On Wed, Oct 19, 2016 at 11:49:56PM +0200, Alexander Bluhm wrote:
> Hi,
>
> I would like to pass a struct pf_pdesc to pf_route() like it is
> done in the other pf functions. That means less parameters, more
> consistency and later I can call functions that need an pd from
> pf_route().
>
> Unfort
On Mon, Oct 24, 2016 at 09:56:13AM +0200, Rafael Zalamena wrote:
> tun(4)/tap(4) function tun_dev_write() is checking for the wrong size for
> the mbuf packet header. We must check against MHLEN (the mbuf header data
> storage size) and not MINCLSIZE (smallest amount of data of a cluster).
>
> For
On Fri, Oct 28, 2016 at 04:19:35PM +0200, Nils Frohberg wrote:
> I currently cannot access the local IP of an interface on rdomain 1:
>
> Script started on Fri Oct 28 15:02:20 2016
> $ doas pfctl -d
> pfctl: pf not enabled
> $ doas ifconfig vether0
> vether0: no such interface
> $ doas
On Wed, Nov 02, 2016 at 05:44:14PM +0100, Martin Pieuchot wrote:
> On 28/10/16(Fri) 16:27, Claudio Jeker wrote:
> > On Fri, Oct 28, 2016 at 04:19:35PM +0200, Nils Frohberg wrote:
> > > I currently cannot access the local IP of an interface on rdomain 1:
> > >
> >
On Tue, Nov 08, 2016 at 03:36:22PM +0100, Martin Pieuchot wrote:
> On 04/11/16(Fri) 10:45, Claudio Jeker wrote:
> > On Wed, Nov 02, 2016 at 05:44:14PM +0100, Martin Pieuchot wrote:
> > > [..]
> > > Diff below should fix that by automagically creating a loopback
> &g
On Wed, Nov 09, 2016 at 11:55:19AM +0100, Martin Pieuchot wrote:
> On 08/11/16(Tue) 17:23, Claudio Jeker wrote:
> > On Tue, Nov 08, 2016 at 03:36:22PM +0100, Martin Pieuchot wrote:
> > > [...]
> > > To add 127.0.0.1 properly it's another story as currently netst
On Tue, Nov 15, 2016 at 02:23:33PM +0100, Martin Pieuchot wrote:
> Simply return EOPNOTSUPP like in raw_userreq() rather than defining an
> empty function. This will help reducing reducing recursive splsotnet()
> in pr_usrreq() functions.
>
> ok?
OK claudio
> Index: netmpls/mpls_raw.c
> ==
On Wed, Nov 16, 2016 at 11:38:06AM +0100, Martin Pieuchot wrote:
> I'd like to enforce that pr_usrreq functions are always called at
> IPL_SOFTNET. This will allow us to keep locking simple as soon as
> we trade splsoftnet() for a rwlock.
>
> Most of the PRU_* actions are already called under spl
On Sat, Nov 19, 2016 at 11:38:56AM +, Stuart Henderson wrote:
> On 2016/11/19 10:06, Remi Locherer wrote:
> > Hi,
> >
> > In the output of ospfd -nv I miss metric and type for the redistribute
> > statement. The below patch adds this.
>
> OK with me. This prints the values when they're at def
On Tue, Nov 22, 2016 at 04:55:17PM +0100, Martin Pieuchot wrote:
> After the last IPSEC-related refactoring this goto no longer make sense.
>
> ok?
Are you shure? I'm not convinced that for an INADDR_BROADCAST destination
the code would do the same. I think it is fine but I can't prove it.
> In
On Wed, Nov 23, 2016 at 11:02:49AM +0100, Martin Pieuchot wrote:
> On 23/11/16(Wed) 06:00, Claudio Jeker wrote:
> > On Tue, Nov 22, 2016 at 04:55:17PM +0100, Martin Pieuchot wrote:
> > > After the last IPSEC-related refactoring this goto no longer make sense.
> > >
On Sun, Dec 18, 2016 at 08:57:23AM +0100, Stefan Sperling wrote:
> Anybody?
>
> Did I write too much of a wall of text to explain the diff?
> In that case, just read the diff. It should make sense.
>
> On Sun, Dec 11, 2016 at 04:38:44PM +0100, Stefan Sperling wrote:
> > This diff makes 'tcpdump -
On Wed, Dec 21, 2016 at 12:08:23PM +0100, Jeremie Courreges-Anglas wrote:
>
> Hi,
>
> After ospfd here's a diff to make ospf6d refresh his view of an
> interface's MTU at runtime. This needs a fresh kernel.
>
> The parent should pass the IFINFO message to its children first, and
> then decide t
On Wed, Dec 21, 2016 at 10:40:48AM +0100, Franco Fichtner wrote:
> Hi,
>
> Switching from net-snmp to OpenBSD's snmpd raised two
> issues and I'd like to know if they make sense to address:
>
> A pid file is missing. Would a patch for this be accepted?
Most probably not. We don't see the benefi
On Tue, Dec 27, 2016 at 02:55:08PM +0100, Jeremie Courreges-Anglas wrote:
>
> struct rroute has ben removed from ospfd some time ago. struct kroute
> takes an additional 'metric' field.
>
Reads good. OK claudio@
>
> Index: kroute.c
> ===
On Fri, Dec 23, 2016 at 04:16:11PM +0100, Jeremie Courreges-Anglas wrote:
>
> In the neighbor fsm, NBR_ACT_DEL frees the neighbor structure. But
> fields of this structure are later accessed, this is mostly visible with
> debug output:
>
> nbr_del: neighbor ID 10.64.55.33, peerid 3
> nbr_fsm: ev
On Tue, Jun 23, 2015 at 03:01:54PM +0200, Martin Pieuchot wrote:
> When an interface is detached or destroyed the CPU executing if_detach()
> removes all the mbufs received by this interface on three queues:
> ARP, IPv4 and IPv6 protocol queues.
>
> This made sense to avoid referencing a dangling
On Fri, Jun 26, 2015 at 04:59:32AM +0300, Sergey Ryazanov wrote:
> Hello,
>
> during building l2tp tunnel with xl2tpd-1.3.1 I was faced with its too
> low upload performance. When download, the speed is 20 mbit/s at
> nearly 100% CPU utilization. CPU is Pentium D 930 3 GHz. When upload,
> t
On Wed, Jul 08, 2015 at 11:02:44AM +0200, Martin Pieuchot wrote:
> I'd like to remove unused/NULL arguments from nd6_nud_hint() in order to
> get rid of a nd6_lookup().
>
> Ok?
Do it. OK claudio
> Index: netinet/tcp_input.c
> ===
>
So mpi@ fixed a problem with connected routes in bgpd. It is time to
update all the other kroute.c implementations as well.
ospfd, ospf6d, ripd, ldpd and snmpd (which I'm unsure about)
Please test
--
:wq Claudio
Index: kroute.c
===
On Tue, Jul 14, 2015 at 07:57:32PM +0200, Martin Pieuchot wrote:
> On 07/07/15(Tue) 18:02, Martin Pieuchot wrote:
> > Maybe not yet but at least I'd like to do the ARP request a bit later.
> >
> > We create a RTF_LOCAL route entry for every configured address. So
> > use this information to emit
On Fri, Jul 17, 2015 at 03:24:17PM -0300, Rafael Zalamena wrote:
> This diff adds support for detection of pseudowires inside of MPLS tagged
> packets. Basically it teaches MPLS to look for ethernet headers when there
> is no sign of IP headers.
The addition of controlword_print() is for sure OK.
Anyone running snmpd that can test this diff?
It should help better report connected routes in -current.
Similar diffs were commited to various routing daemons already.
--
:wq Claudio
Index: kroute.c
===
RCS file: /cvs/src/usr.sbin
On Fri, Jul 17, 2015 at 07:43:11PM -0500, Brent Cook wrote:
> /dev/null will be available on any POSIX system, but _PATH_DEVNULL may
> not, e.g. Solaris. There doesn't seem to be any advantage to
> using the define (and we don't use it much in the tree either.)
Also OK claudio@
> http://pubs.ope
On Fri, Jul 17, 2015 at 07:41:11PM -0500, Brent Cook wrote:
> This diff converts bzero calls to memset, which is more portable and
> compilers can optimize as well.
OK claudio@
> ---
> src/usr.sbin/ntpd/client.c | 2 +-
> src/usr.sbin/ntpd/config.c | 6 +++---
> src/usr.sbin/ntpd/control.c |
On Sat, Jul 18, 2015 at 07:14:27PM +0200, Martin Pieuchot wrote:
> This applies phessler@'s logic to *all* the commands supporting the
> "-priority" switch. Plus some KNF.
>
> ok?
OK claudio@
> Index: route.c
> ===
> RCS file: /cv
On Mon, Jul 20, 2015 at 09:32:20PM +, Johan Ymerson wrote:
> On Mon, 2015-07-20 at 22:58 +0200, Martin Pieuchot wrote:
> > On 20/07/15(Mon) 19:10, Johan Ymerson wrote:
> > > On 2015-07-18 16:03:00, Martin Pieuchot wrote:
> > > > Committed! Thanks and sorry for the delay.
> > >
> > > Hi!
> > >
On Mon, Sep 07, 2015 at 03:49:14PM -0400, Michael McConville wrote:
> It seems pretty clear to me that what was here was wrong. A field of a
> global struct was pointed at local array. The program logic was a little
> wacky, but this is my best estimate of what was intended. Input?
>
>
> Index: p
On Tue, Sep 08, 2015 at 02:31:32AM -0400, Michael McConville wrote:
> Claudio Jeker wrote:
> > On Mon, Sep 07, 2015 at 03:49:14PM -0400, Michael McConville wrote:
> > > It seems pretty clear to me that what was here was wrong. A field of
> > > a global struct was
This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
Seems to work for me but don't expect any miracles.
Please test
--
:wq Claudio
Index: if_ix.c
===
RCS file: /cvs/src/sys/dev/pci/if_ix.c,v
retrieving revisio
On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
> On 9.9.2015. 10:10, Claudio Jeker wrote:
> > This is a port of the em(4) IPL_MPSAFE changes made by kettenis@ to ix(4).
> > Seems to work for me but don't expect any miracles.
> >
> > Please test
On Thu, Sep 10, 2015 at 10:25:59AM +0200, Martin Pieuchot wrote:
> We're sure the parent is alive when a cloned route is removed from the
> table because removing the parent kill all the children.
>
> Ok?
OK
> Index: net/route.c
>
in6_embedscope() needs to lose some weight. Remove the last argument.
In all but two calls NULL is passed and in the other 2 cases the ifp
is only used to maybe feed it to in6_selecthlim() to select the hoplimit
for the link. Since in6_embedscope() only works on link-local addresses
it does not ma
On Thu, Sep 10, 2015 at 02:36:41PM -0400, Michael McConville wrote:
> These seem like they were definitely meant to be explicit zeroings.
>
OK claudio@
>
> Index: pfkey.c
> ===
> RCS file: /cvs/src/usr.sbin/bgpd/pfkey.c,v
> retriev
On Fri, Sep 11, 2015 at 12:11:07AM +0200, Hrvoje Popovski wrote:
> On 10.9.2015. 17:02, Hrvoje Popovski wrote:
> > On 10.9.2015. 9:57, Claudio Jeker wrote:
> >> On Wed, Sep 09, 2015 at 11:57:57PM +0200, Hrvoje Popovski wrote:
> >>> On 9.9.2015. 10:10, Claudio Jeker w
Kill yet another argument to functions in IPv6. This time ip6_output
ifpp - XXX: just for statistics
ifpp is always NULL in all callers so that statistic confirms ifpp is
dying
--
:wq Claudio
Index: net/if_gif.c
===
RCS file: /cvs/s
On Fri, Sep 11, 2015 at 02:21:54PM +0200, Martin Pieuchot wrote:
> In order to keep if_get()/if_put() dances in the same function, I need
> to change in6_selectroute() to no longer return an ``ifp''.
>
> This is a first step towards this goal. It moves the multicast code out
> of in6_selectroute(
On Sat, Sep 12, 2015 at 10:06:12AM +0200, Martin Pieuchot wrote:
> Now that rtrequest1(9) properly set RTF_UP when a route is added,
> there's no need to pass it to rt_ifa_add(9).
>
> rt_ifa_del(9) never needed it, but it has been set for documentation.
>
> ok?
Yes, go for it. OK claudio@
> In
On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote:
> inpt_lastport is never read without being written before, and only
> in_pcbbind()
> and in6_pcbsetport() are using it. This diff removes inpt_lastport from
> struct inpcbtable and turns it into a local variable where it is used.
>
>
On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote:
> On 09/12/15 22:10, Claudio Jeker wrote:
> > On Sat, Sep 12, 2015 at 02:40:59PM +0200, Vincent Gross wrote:
> >> inpt_lastport is never read without being written before, and only
> >> in_pcbbind()
> >
On Fri, Sep 11, 2015 at 09:18:18PM +0200, Maxime Villard wrote:
> Got some time tonight; nothing new, just emptying my list:
>
> http://m00nbsd.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html#Unsorted-2
>
> Summary:
>
> _17/ UNINITIALIZED VARIABLE: sys/netinet/if_ether.c rev1.165
> _18/ UNINITIA
On Wed, Sep 16, 2015 at 11:03:23AM +0200, Stefan Sperling wrote:
> On Fri, Sep 11, 2015 at 09:18:18PM +0200, Maxime Villard wrote:
> > _18/ UNINITIALIZED VARIABLE: sys/net80211/ieee80211_pae_output.c rev1.20
>
> This code is correct but I can see how it's hard to tell for a code scanner.
> The onl
On Fri, Sep 18, 2015 at 02:58:40PM +0200, Vincent Gross wrote:
> On 09/13/15 11:49, Vincent Gross wrote:
> > On 09/13/15 10:37, Claudio Jeker wrote:
> >> On Sun, Sep 13, 2015 at 12:18:10AM +0200, Vincent Gross wrote:
> >>> On 09/12/15 22:10, Claudio Jeker wrote:
>
On Tue, Sep 22, 2015 at 03:14:18PM +0200, Martin Pieuchot wrote:
> Instead of incrementing the rt_use counter when a rtalloc(9) call
> succeeds, let's do it inside ralloc(9).
>
> The route(8) regress tests will need to be updated because all the
> paths calling rtalloc(9) do not increment rt_use.
On Sat, Sep 26, 2015 at 09:58:59PM +0200, Stefan Sperling wrote:
> On Sat, Sep 26, 2015 at 03:51:25PM -0400, Michael McConville wrote:
> > Stefan Sperling wrote:
> > > On Sat, Sep 26, 2015 at 03:29:07PM -0400, Michael McConville wrote:
> > > > I see some preproc conditions in usr.sbin/snmpctl/snmpc
On Fri, Oct 02, 2015 at 11:09:06AM +0100, Stuart Henderson wrote:
> On 2015/10/01 14:35, Jason McIntyre wrote:
> > CVSROOT:/cvs
> > Module name:src
> > Changes by: j...@cvs.openbsd.org2015/10/01 14:35:55
> >
> > Modified files:
> > libexec/login_radius: login_radius.8
> >
On Thu, Oct 22, 2015 at 06:50:01PM +0200, Martin Pieuchot wrote:
> On 19/10/15(Mon) 14:07, Martin Pieuchot wrote:
> > This function is a no-op, let's kill it.
>
> Anybody?
What could go wrong? (mwhahahaha)
Put it in and lets see on which dragons tail we're jumping around this
time.
> >
> > I
On Sat, Oct 24, 2015 at 12:37:44PM -0600, Kevin Reay wrote:
> Adopt an updated version of the tcpdump.org ASN size calculation for
> BGP UPDATE message AS_PATHs. This corrects some bad behaviour due to
> incorrect ASN size calculations.
>
> I believe that the current way of calculating the ASN siz
On Sat, Oct 24, 2015 at 06:22:10PM +0200, Martin Pieuchot wrote:
> On 24/10/15(Sat) 18:01, Martin Pieuchot wrote:
> > Revamping the network stack design continue here at u2k15...
> >
> > This times it's about the L2 resolution mechanism plugged into the
> > routing table. While discussing with A
On Sat, Oct 24, 2015 at 07:04:52PM +0200, Alexander Bluhm wrote:
> Hi,
>
> Instead of doing the the if_get() dance for rt_missmsg(), change the
> function to take an interface index.
>
> ok?
Yes
> bluhm
>
> Index: net/route.c
> =
Some stuff I found while looking at kroute code is that the kernel is not
always filling the info in the same way. This tries to fix this.
First of all make sure the RTM_GET lookups fill out rtm_index no matter
what. We do the same thing in the sysctl code and also in most other RTM_*
messages.
Sec
On Tue, Sep 19, 2017 at 04:54:04PM +1000, David Gwynne wrote:
> this helsp if you want to have a tap interface joined to a bridge
> on boot.
>
> ok?
Uhm, why? bridge is already delayed and tap will be initialized therefore
before bridge? Neither tun nor tap should be in that list in my opinion
si
On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote:
> Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed
> when creating new bridge and attaching interfaces to it.
>
> Comments? Ok?
I don't think it is a good idea to destroy and recreate bridge interfaces
on every reloa
On Tue, Oct 10, 2017 at 10:52:42PM -0700, Mike Larkin wrote:
> On Wed, Oct 11, 2017 at 06:46:22AM +0200, Claudio Jeker wrote:
> > On Tue, Oct 10, 2017 at 03:57:25PM -0700, Carlos Cardenas wrote:
> > > Destroy switch on `vmctl reload` to allow SIOCBRDGADD to succeed
> > &g
On Mon, Oct 16, 2017 at 10:15:28AM +0200, Martin Pieuchot wrote:
> Hrvoje Popovski reported the following panic:
>
> panic: kernel diagnostic assertion "sc->sc_carpdev != NULL" failed
> panic() at panic+0x128
> __assert() at __assert+0x24
> carp_output() at carp_output+0xde
> ip_output()
On Wed, Oct 18, 2017 at 01:34:27PM +0200, Martin Pieuchot wrote:
> Kill ioctl(2) added with original KAME import that have never been used.
> FreeBSD also stopped supporting them in 2013.
>
> ok?
Agreed, if it builds OK claudio. The amount of - is shocking...
> Index: sys/sockio.h
> ===
OK claudio@
On Thu, Oct 19, 2017 at 04:34:35PM +1100, Jonathan Gray wrote:
> Index: parse.y
> ===
> RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v
> retrieving revision 1.315
> diff -u -p -r1.315 parse.y
> --- parse.y 21 Aug 2017 14:41:
1701 - 1800 of 2323 matches
Mail list logo
