Re: biodone() and splbio ?

2010-01-21 Thread Manuel Bouyer
On Tue, Jan 19, 2010 at 10:52:49PM +0100, Manuel Bouyer wrote: On Tue, Jan 19, 2010 at 10:43:04PM +0100, Manuel Bouyer wrote: [...] If not, dk.c needs to be fixed to raise to splbio() in its done routine. raidcframe already does it. I suspect ccdiodone() and vndiodone() need it too.

Re: blocksizes

2010-01-21 Thread David Holland
On Thu, Jan 21, 2010 at 10:30:20PM +, Michael van Elst wrote: IMHO there need to be three different ways to specify block offsets and block counts: 1. in units of blocks of the physical device 2. in units of blocks of DEV_BSIZE bytes 3. in bytes Don't forget: 4. in units of the

Re: blocksizes

2010-01-21 Thread Robert Elz
Date:Fri, 22 Jan 2010 08:07:03 +0100 From:Michael van Elst mlel...@serpens.de Message-ID: 20100122070702.ga10...@serpens.de | except that there a lot of assumptions that | physical block size is the same as DEV_BSIZE. Is that really true these days? I believe

Re: blocksizes

2010-01-21 Thread Michael van Elst
k...@munnari.oz.au (Robert Elz) writes: Like most things, there is no universal correct answer here, simply deciding always use bytes because it seems simpler is unlikely to be the overall best answer. I think the suggestion is to use block numbers (or some other form of addressing larger units)

Re: blocksizes

2010-01-21 Thread Michael van Elst
On Fri, Jan 22, 2010 at 02:28:07PM +0700, Robert Elz wrote: Date:Fri, 22 Jan 2010 08:07:03 +0100 From:Michael van Elst mlel...@serpens.de Message-ID: 20100122070702.ga10...@serpens.de | except that there a lot of assumptions that | physical block size is the