Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread Iain Hibbert
On Thu, 18 Feb 2010, KIYOHARA Takashi wrote: > > (btw, no comma is permitted on final enum values) > > This is because of convenient for the addition in the future. The diff > becomes smaller. ;-) Yes, except C89 and C++ do not permit that, so gcc (also lint?) makes complaints about it. It is n

Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread Martin Husemann
On Thu, Feb 18, 2010 at 11:53:50AM +, Iain Hibbert wrote: > Yes, except C89 and C++ do not permit that, so gcc (also lint?) makes > complaints about it. It is not "reasonable" alas. Nitpick: C++ and C99 do allow it, gcc does not complain (at least I couldn't get it to complain with any -std= a

Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread Iain Hibbert
On Thu, 18 Feb 2010, KIYOHARA Takashi wrote: + if (m->m_pkthdr.len & 0x1) { + m_copyback(m, m->m_pkthdr.len, 1, &dtlh.rsvd); /* Add pad */ I wonder if handling this pad byte separately would be useful? The reason I ask, is that as far as I recall, m_copyback() does always ex

Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread KIYOHARA Takashi
Hi! Iain, From: Iain Hibbert Date: Thu, 18 Feb 2010 11:53:50 + (GMT) > On Thu, 18 Feb 2010, KIYOHARA Takashi wrote: > > > +static int > > > +btuart_dtl_probe(dev_t dev) > > > +{ > > > +#if NCOM > 0 > >: > > > +#endif > > > + return 0; > > > +} > > > > > > I really dislike this function

enumeration of bicycle sheds

2010-02-18 Thread Iain Hibbert
On Thu, 18 Feb 2010, Terry Moore wrote: > Looking at C99, trailing commas _are_ allowed in enum lists. I know that, but C89 expressly forbade it and apparently C++ is similar. I'm not claiming that its reasonable and incidentally, share/misc/style says to not use the comma.. If you or anybody wa

Proposed changes to the dbcool(4) driver

2010-02-18 Thread Paul Goyette
Folks, When the dbcool(4) driver was commited, sysmon_envsys(9) did not have the ability to retrieve and set sensor limit values in the hardware device. As a result, dbcool had a separate user interface, using sysctl(8), for this purpose. Now that sysmon_envsys has grown the required capabi

Re: enumeration of bicycle sheds

2010-02-18 Thread Terry Moore
Sorry, misread original comment -- C89 appeared as C99. Old eyes can be as bad as old ears for intelligent discussion --Terry t...@mcci.comtel: +1-607-277-1029fax: +1-607-277-6844www.mcci.com On 2/18/2010 8:18 AM, Iain Hibbert wrote: On Thu, 18 Feb 2010, Terry Moore wrote:

Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread Terry Moore
Looking at C99, trailing commas _are_ allowed in enum lists. 6.7.2.2 Enumeration specifiers Syntax 1 enum-specifier: enum identifieropt { enumerator-list } enum identifieropt { enumerator-list , } --Terry t...@mcci.comtel: +1-607-277-1029fax: +1-607-277-6844www.mcci.com On 2/18/20

Re: enumeration of bicycle sheds

2010-02-18 Thread Alistair Crooks
On Thu, Feb 18, 2010 at 01:18:54PM +, Iain Hibbert wrote: > actually caused warnings then I would be more inclined to use it. In the > meantime, I generally prefer #define but am not greatly attached. whilst bicycles are a - particularly - sore point for me right now, the reason that used to b

Re: enumeration of bicycle sheds

2010-02-18 Thread James Chacon
On Thu, Feb 18, 2010 at 7:18 AM, Iain Hibbert wrote: > On Thu, 18 Feb 2010, Terry Moore wrote: > >> Looking at C99, trailing commas _are_ allowed in enum lists. > > I know that, but C89 expressly forbade it and apparently C++ is similar. > I'm not claiming that its reasonable and incidentally, sha

Re: enumeration of bicycle sheds

2010-02-18 Thread Joerg Sonnenberger
On Thu, Feb 18, 2010 at 05:43:15PM +0100, Alistair Crooks wrote: > On Thu, Feb 18, 2010 at 01:18:54PM +, Iain Hibbert wrote: > > actually caused warnings then I would be more inclined to use it. In the > > meantime, I generally prefer #define but am not greatly attached. > > whilst bicycles ar

Re: btuart and SOCKET Bluetooth CF

2010-02-18 Thread Iain Hibbert
On Thu, 18 Feb 2010, KIYOHARA Takashi wrote: > Hi! Iain, > > From: Iain Hibbert > Date: Thu, 18 Feb 2010 11:53:50 + (GMT) > > > On Thu, 18 Feb 2010, KIYOHARA Takashi wrote: > > > > > +static int > > > > +btuart_dtl_probe(dev_t dev) > > > > +{ > > > > +#if NCOM > 0 > > >: > > > > +#endif >

Re: DTrace port

2010-02-18 Thread Darran Hunt
The i386 platform is the platform of interest for my employer, hence its the first platform for the port. The FreeBSD port also has AMD64 support so that shouldn't be too difficult to add to NetBSD. br, Darran. On 15/02/2010, at 9:20 PM, Volker A. Brandt wrote: Courtesy of CoyotePoint Syst

sysctl node names (Re: CVS commit: src/sys/uvm)

2010-02-18 Thread YAMAMOTO Takashi
hi, > Module Name: src > Committed By: drochner > Date: Thu Feb 18 14:57:01 UTC 2010 > > Modified Files: > src/sys/uvm: files.uvm uvm_map.c > > Log Message: > Disable mapping of virtual address 0 by user programs per default. > This blocks an easy exploit of kernel bugs leading to