Re: Length of wmesg for condvar?

2010-08-09 Thread Matthew Mondor
On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette p...@whooppee.com wrote: Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters? It seems to me that the exporter of those use strncpy() (i.e. kern/init_sysctl.c) and that the structures use

Re: Using coccinelle for (quick?) syntax fixing

2010-08-09 Thread Jean-Yves Migeon
On Sun, 8 Aug 2010 14:45:59 -0400, Matthew Mondor mm_li...@pulsar-zone.net wrote: On Sun, 08 Aug 2010 18:05:11 +0200 Jean-Yves Migeon jeanyves.mig...@free.fr wrote: Opinions? Any interest in it? My intent is to put NetBSD specific scripts on wiki.n.o, and provide links for more generic

Re: Using coccinelle for (quick?) syntax fixing

2010-08-09 Thread Antti Kantee
On Mon Aug 09 2010 at 11:20:29 +0200, Jean-Yves Migeon wrote: It is 'error-prone, in the sense that it can raise false positives. But when you get more familiar with it, you can either fix the cocci patch (easy for __arraycount, I missed one of the cases... less obvious for aprint stuff), and

Re: Using coccinelle for (quick?) syntax fixing

2010-08-09 Thread Jean-Yves Migeon
On Mon, 9 Aug 2010 13:27:38 +0300, Antti Kantee po...@cs.hut.fi wrote: I really dislike untested wide-angle churn, especially if there is 0 measurable gain. Converting code to __arraycount is a prime example. The only benefit of __arraycount is avoiding typing and therefore typos. Neither of

Re: Length of wmesg for condvar?

2010-08-09 Thread David Laight
On Mon, Aug 09, 2010 at 02:38:32AM -0400, Matthew Mondor wrote: On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette p...@whooppee.com wrote: Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters? It seems to me that the exporter of those

Re: Using coccinelle for (quick?) syntax fixing

2010-08-09 Thread Jean-Yves Migeon
On 09.08.2010 18:45, Antti Kantee wrote: On Mon Aug 09 2010 at 18:19:28 +0200, Jean-Yves Migeon wrote: That said, if $someone can produce a set of rules which showably find bugs in NetBSD code and do not produce a lot of false positives, I'm very interested in seeing nightly runs. Alright,

Re: Length of wmesg for condvar?

2010-08-09 Thread Paul Goyette
On Mon, 9 Aug 2010, Matthew Mondor wrote: On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette p...@whooppee.com wrote: Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters? It seems to me that the exporter of those use strncpy() (i.e.

re: Length of wmesg for condvar?

2010-08-09 Thread matthew green
On Mon, Aug 09, 2010 at 02:38:32AM -0400, Matthew Mondor wrote: On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette p...@whooppee.com wrote: Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters? It seems to me that the exporter

Re: Length of wmesg for condvar?

2010-08-09 Thread Matthew Mondor
On Mon, 9 Aug 2010 22:21:02 +0100 David Laight da...@l8s.co.uk wrote: On Mon, Aug 09, 2010 at 02:02:51PM -0700, Paul Goyette wrote: Does anyone object to my going through and coming up with shorter names (= 8 chars) for these condvars? It is worth chcking whether they are displayed

Re: pchb@acpi

2010-08-09 Thread David Young
On Mon, Aug 02, 2010 at 06:42:11PM +0900, KIYOHARA Takashi wrote: Hi! Quentin, From: Quentin Garnier c...@cubidou.net Date: Sun, 1 Aug 2010 15:21:18 + On Sun, Aug 01, 2010 at 11:17:54PM +0900, KIYOHARA Takashi wrote: All recent PC has information on PCI in ACPI. We can

Re: pchb@acpi

2010-08-09 Thread Eduardo Horvath
On Mon, 9 Aug 2010, David Young wrote: What kind of segment information? Attached is a preview of information that I supply to instances of pci(4), ppb(4), and cbb(4) through their device properties. The information will help them manage PCI address spaces and to program their address

Re: Using coccinelle for (quick?) syntax fixing

2010-08-09 Thread Robert Elz
Date:Mon, 09 Aug 2010 18:19:28 +0200 From:Jean-Yves Migeon jeanyves.mig...@free.fr Message-ID: e2568087e60b3c2943d03413cd7e5...@localhost I agree with pooka, no code changes to existing code just to make the code look better. | However, I would prefer to have code