IOC_CPU_SETSTATE

2011-07-03 Thread Alexander Nasonov
Hi, This code error = cpu_setintr(ci, cs->cs_intr); error = cpu_setstate(ci, cs->cs_online); in cpuctl_ioctl doesn't look right. Is there any reason why new IOC constant had not been introduced when adding intr/nointr support? BTW, intr/nointr is not documented in cp

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Manuel Bouyer
On Sun, Jul 03, 2011 at 08:31:00PM +0300, Jukka Ruohonen wrote: > On Sun, Jul 03, 2011 at 07:27:00PM +0200, Manuel Bouyer wrote: > > it's not only about Xen, it's about all kernels for any port which > > already have DIAGNOSTIC and want to keep it even for release > > (e.g. i386 ALL). > > As far a

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Jukka Ruohonen
On Sun, Jul 03, 2011 at 07:27:00PM +0200, Manuel Bouyer wrote: > it's not only about Xen, it's about all kernels for any port which > already have DIAGNOSTIC and want to keep it even for release > (e.g. i386 ALL). As far as I understand, i386/ALL is just for testing the compilation of various opti

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Manuel Bouyer
On Sun, Jul 03, 2011 at 06:23:49PM +0100, Mindaugas Rasiukevicius wrote: > Manuel Bouyer wrote: > > On Sun, Jul 03, 2011 at 04:17:02PM +0100, Mindaugas Rasiukevicius wrote: > > > Manuel Bouyer wrote: > > > > > > > > > > - Obviously, defined policy/responsibility to disable these options > > > >

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Mindaugas Rasiukevicius
Manuel Bouyer wrote: > On Sun, Jul 03, 2011 at 04:17:02PM +0100, Mindaugas Rasiukevicius wrote: > > Manuel Bouyer wrote: > > > > > > > > - Obviously, defined policy/responsibility to disable these options > > > > for release kernels. In fact, if we go this way - then options > > > > should be r

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Manuel Bouyer
On Sun, Jul 03, 2011 at 04:17:02PM +0100, Mindaugas Rasiukevicius wrote: > Manuel Bouyer wrote: > > > > > > - Obviously, defined policy/responsibility to disable these options for > > > release kernels. In fact, if we go this way - then options should be > > > removed from all MD kernel conf

Re: add DIAGNOSTIC back to GENERIC/INSTALL

2011-07-03 Thread Mindaugas Rasiukevicius
Manuel Bouyer wrote: > > > > - Obviously, defined policy/responsibility to disable these options for > > release kernels. In fact, if we go this way - then options should be > > removed from all MD kernel configs and managed in MI src/sys/conf/std. > > I'm not sure this is doable: some port