Re: Another MII PHY fix.

2013-06-09 Thread SAITOH Masanobu
Hi. (2013/06/09 18:43), Mouse wrote: > I don't know this stuff in enough detail to vet the code more than > trivially. But I do notice one minor issue and one possible issue: > >>> /* >>> +* mii_tick == 0 means it's the first tick after changing the media or >>> +* the link became d

Re: Another MII PHY fix.

2013-06-09 Thread Mouse
I don't know this stuff in enough detail to vet the code more than trivially. But I do notice one minor issue and one possible issue: >> /* >> + * mii_tick == 0 means it's the first tick after changing the media or >> + * the link became down since the last tick (see above), so retur

Re: Another MII PHY fix.

2013-06-09 Thread SAITOH Masanobu
(2013/06/06 15:48), Masanobu SAITOH wrote: > > Hi, all. > > Without following patch. Some drivers which don't use link > interrput check the link status only every sc->mii_anegticks. > It's late. The patch is a part of FreeBSD's mii_physubr.c r158649: > > > http://svnweb.freebsd.org/base/hea