On Mar 19, 2014, at 1:17 PM, Ilya Zykov wrote:
>> |*--bp = '\0';
>> | - error = getcwd_common(cwdi->cwdi_rdir, rootvnode, &bp,
>> | + error = getcwd_common(mp->mnt_vnodecovered, cwdi->cwdi_rdir, &bp,
>> |buf, MAXBUF / 2, 0, l);
>>
>> Might as well pass NULL for cwdi->cwdi_rdir, si
> | > People did not like that.
> |
> | Didn't like what "if 1" or "return EBUSY"?
>
> The return EBUSY...
>
Ok, but bug will stay in the system, temporarily.
fs/ptyfs/ptyfs_vfsops.c | 16 +++-
kern/tty_ptm.c |9 -
2 files changed, 19 insertions(+), 6 deletions
On Mar 19, 9:51pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
| Ok, but bug will stay in the system, temporarily.
No problem, no worse than we have now.
christos
|
| fs/ptyfs/ptyfs_vfsops.c | 16 +++-
| kern/tty_ptm.c |
On Mar 19, 9:17pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
| > Might as well pass NULL for cwdi->cwdi_rdir, since it does the same.
|
| But it is less obvious, and haven't advantage.
I guess you need cwdi earlier anyway to shortcut this...
> | *--bp = '\0';
> | - error = getcwd_common(cwdi->cwdi_rdir, rootvnode, &bp,
> | + error = getcwd_common(mp->mnt_vnodecovered, cwdi->cwdi_rdir, &bp,
> | buf, MAXBUF / 2, 0, l);
>
> Might as well pass NULL for cwdi->cwdi_rdir, since it does the same.
>
But it is less obvious, an
On Mar 19, 6:09pm, net...@izyk.ru (Ilya Zykov) wrote:
-- Subject: Re: Enhance ptyfs to handle multiple instances.
| Index: nbcur/src/sys/fs/ptyfs/ptyfs_vfsops.c
| diff -u nbcur/src/sys/fs/ptyfs/ptyfs_vfsops.c:1.1.1.1
nbcur/src/sys/fs/ptyfs/ptyfs_vfsops.c:1.7
| --- nbcur/src/sys/fs/ptyfs/ptyfs_vf
Hello!
For not accumulate many changes and keep patch clear.
I am sending some error fix and modifications for future work and discussion
too.
Please, if possible, include it in current tree.
Little explanations:
1. We shouldn't mount more than one ptyfs.(dependency from unmount order).
Pa
