Re: Vnode API change: add global vnode cache

2014-04-08 Thread Alan Barrett
On Tue, 08 Apr 2014, Mindaugas Rasiukevicius wrote: Nothing [in NetBSD] really uses intern. Perhaps not a great naming, but other subsystems usually just use get. Yes, that's a good argument for just using get. --apb (Alan Barrett)

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Martin Husemann
On Tue, Apr 08, 2014 at 12:25:32AM -0400, Thor Lancelot Simon wrote: 2) Accumulate the output of kernel printf (as well as the times when it's called) and add this periodically. To avoid issues with recursion through diagnostic printfs, we use SHA512 to

Re: Vnode API change: add global vnode cache

2014-04-08 Thread J. Hannken-Illjes
On 07 Apr 2014, at 19:28, Chuck Silvers c...@chuq.com wrote: On Sun, Apr 06, 2014 at 12:14:24PM +0200, J. Hannken-Illjes wrote: Currently all file systems have to implement their own cache of vnode / fs node pairs. Most file systems use a copy and pasted version of ufs_ihash. So add a

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Thor Lancelot Simon
On Tue, Apr 08, 2014 at 09:39:12AM +0200, Martin Husemann wrote: On Tue, Apr 08, 2014 at 12:25:32AM -0400, Thor Lancelot Simon wrote: 2) Accumulate the output of kernel printf (as well as the times when it's called) and add this periodically. To avoid issues

Rewrite kernfs and procfs.

2014-04-08 Thread Ilia Zykov
Hello! I desire become a NetBSD developer and develop this project. Sorry to disturb, maybe I need anything else. Also little patch, that removes unusable hack(any more, see below) from kernfs and returns its work. kernfs can't works from this commit(Wed Feb 13 14:03:48 2013 UTC): Make the

Re: Rewrite kernfs and procfs.

2014-04-08 Thread Christos Zoulas
On Apr 8, 9:15pm, net...@izyk.ru (Ilia Zykov) wrote: -- Subject: Rewrite kernfs and procfs. | Hello! | I desire become a NetBSD developer and develop this project. Excellent... | Sorry to disturb, maybe I need anything else. What else do you need? | Also little patch, that removes unusable

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Thor Lancelot Simon
On Tue, Apr 08, 2014 at 12:25:32AM -0400, Thor Lancelot Simon wrote: Attached are the changes from the tls-earlyentropy branch, which tries to make the output of /dev/random less predictable -- particularly for an attacker outside the box -- earlier. I have observed a buglet though I haven't

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Mindaugas Rasiukevicius
Thor Lancelot Simon t...@panix.com wrote: Attached are the changes from the tls-earlyentropy branch, which tries to make the output of /dev/random less predictable -- particularly for an attacker outside the box -- earlier. This is a very positive work for the cases when system is used as a

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Thor Lancelot Simon
On Wed, Apr 09, 2014 at 02:43:23AM +0100, Mindaugas Rasiukevicius wrote: This is a very positive work for the cases when system is used as a server or other workloads which may involve cryptographic activity. However, you seem to assume that aggressive entropy collection is always preferable

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Dave Huang
On Apr 8, 2014, at 21:33, Thor Lancelot Simon t...@panix.com wrote: On Wed, Apr 09, 2014 at 02:43:23AM +0100, Mindaugas Rasiukevicius wrote: Few fragments which caught my eye while skimming through the diff.. #if defined(__HAVE_CPU_COUNTER) - if (cpu_hascounter()) - return

Re: Changes to make /dev/*random better sooner

2014-04-08 Thread Thor Lancelot Simon
On Tue, Apr 08, 2014 at 09:45:47PM -0500, Dave Huang wrote: I don't have any knowledge or opinion about that, but maybe the ?? has to do with the sizeof? I think the parens are wrong; they're around the entire equality comparison. Hell. Yes they are. Thanks both of you for this catch.