Re: Patch: cprng_fast performance - please review.

2014-04-17 Thread Thor Lancelot Simon
On Wed, Apr 16, 2014 at 09:52:22PM -0400, Thor Lancelot Simon wrote: > > Attached is a patch which makes cprng_fast per-CPU and lockless. *IT IS NOT > WELL TESTED YET (I haven't even run test vectors) AND IS ONLY FOR REVIEW.* New diff, with some missing files and incorporating some more comments

Re: Patch: cprng_fast performance - please review.

2014-04-17 Thread Taylor R Campbell
Repeating what I said privately for the public record: The changes to cprng.h expose a lot of guts of the new cprng_fast implementation. I don't see justification for this. As I understand it, the goals of rewriting cprng_fast are: 1. Replace the unsafe arc4random by a safer algorithm. 2. Impro

Re: Patch: cprng_fast performance - please review.

2014-04-17 Thread Thor Lancelot Simon
Thank you for looking at this! On Thu, Apr 17, 2014 at 09:33:28PM +, Taylor R Campbell wrote: > > And the only performance constraint is that its single-threaded > performance should not be worse than the existing arc4random-based > cprng_fast. This, I don't agree with, unless we're going to