Re: serious performance regression in .41

2014-05-24 Thread J. Hannken-Illjes
On 23 May 2014, at 20:15, Christos Zoulas chris...@astron.com wrote: In article dfc486af-ca51-4ec2-b132-cd5e06b03...@eis.cs.tu-bs.de, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Ok, so I tried a kernel with DEBUG+LOCKDEBUG and get the same problems you describe: every 10 to 20 seconds

Re: serious performance regression in .41

2014-05-24 Thread Christos Zoulas
In article 69ce1ce4-6c54-4e17-802d-679a6a165...@eis.cs.tu-bs.de, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Ok, see me convinced. Great :-) First, selector and context should be passed to vfs_vnode_iterator_init as they are invariant. We may (ab)use v_mount and v_data to avoid allocating

Re: serious performance regression in .41

2014-05-24 Thread J. Hannken-Illjes
On 24 May 2014, at 19:32, Christos Zoulas chris...@astron.com wrote: In article 69ce1ce4-6c54-4e17-802d-679a6a165...@eis.cs.tu-bs.de, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Ok, see me convinced. Great :-) First, selector and context should be passed to vfs_vnode_iterator_init

Re: serious performance regression in .41

2014-05-24 Thread Christos Zoulas
In article b06ba1f3-ebb6-414b-a27f-16f1395ee...@eis.cs.tu-bs.de, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Why didn't you commit it then? I just did. We should review all the selector calls. I don't think that calling VOP_GETATTR is ok. If it is not, why doesn't it KASSSET? If you

Re: API/ABI rank of headers in /usr/include/isofs/cd9660

2014-05-24 Thread David Holland
On Wed, May 14, 2014 at 08:00:56AM +1000, matthew green wrote: thanks for looking at this. we've gotten better since early days with these sorts of issues, but there are still a lot of headers that are installed for no good reason but no one has had the chance/motivation to clean them up

Re: API/ABI rank of headers in /usr/include/isofs/cd9660

2014-05-24 Thread David Holland
On Tue, May 13, 2014 at 10:36:08PM +0200, Thomas Schmitt wrote: There are some that may be useful for userland applications to grovel through the physical format, isofs/cd9660/iso.h could be seen as such a thing. udf exposes the equivalent, ecma167-udf.h. But any interested

Re: serious performance regression in .41

2014-05-24 Thread J. Hannken-Illjes
On 24 May 2014, at 20:16, Christos Zoulas chris...@astron.com wrote: In article b06ba1f3-ebb6-414b-a27f-16f1395ee...@eis.cs.tu-bs.de, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Why didn't you commit it then? I just did. I mean this: selector and context should be passed to

Re: API/ABI rank of headers in /usr/include/isofs/cd9660

2014-05-24 Thread Thomas Schmitt
Hi, David Holland wrote: In an ideal world, each filesystem would install two headers: - one with the structures, constants, etc. needed to work with the on-disk format; this would be used by fsck, newfs, makefs, etc. Sounds dangerous for my cause. Obviously my grepping was not good enough

Re: serious performance regression in .41

2014-05-24 Thread Tyler Retzlaff
On 5/24/2014 4:28 AM, Martin Husemann wrote: On Fri, May 23, 2014 at 06:15:10PM +, Christos Zoulas wrote: The hiccups are much less severe, but there are still performance issues. The machine is a lot slower building than it used to be. I see this as well (though no hard numbers). Amd64,