Re: Patch: xhci controller driver improvements

2014-08-11 Thread Takahiro HAYASHI
On 08/11/14 19:40, Nick Hudson wrote: @@ -2889,6 +3028,7 @@ xhci_timeout(void *addr) struct xhci_softc * const sc = xfer->pipe->device->bus->hci_private; if (sc->sc_dying) { +xhci_abort_xfer(xfer, USBD_TIMEOUT); return; } This looks very strange. Does it ne

Re: USB 3.0 xhci questions

2014-08-11 Thread Takahiro HAYASHI
Hello, On 08/11/14 21:51, Ryo ONODERA wrote: Do these xHCIs work on other OS? If yes, hardware seems good. Arch Linux (archlinux-2014.08.01.iso; Linux 3.15.7) works fine on both machines. SuperSpeed USB device is detected and attached to xhci. Hardwares have no problem. Thanks for checking.

Re: USB 3.0 xhci questions

2014-08-11 Thread Ryo ONODERA
Hi, From: Takahiro HAYASHI , Date: Mon, 11 Aug 2014 17:58:12 +0900 > Hello, > > On 08/10/14 22:44, Ryo ONODERA wrote: >> Sadly, if my guess (1) was true, my MacBook Air' and >> Lenovo ThinkStation E32's USB 3.0 does not work. No device is >> detected. > > Do these xHCIs work on other OS? > If

Re: Patch: xhci controller driver improvements

2014-08-11 Thread Nick Hudson
On 08/10/14 12:54, Takahiro HAYASHI wrote: Hi, Hi, On 08/10/14 17:06, Nick Hudson wrote: Some comments... @@ -2889,6 +3028,7 @@ xhci_timeout(void *addr) struct xhci_softc * const sc = xfer->pipe->device->bus->hci_private; if (sc->sc_dying) { +xhci_abort_xfer(xfer, U

Re: USB 3.0 xhci questions

2014-08-11 Thread Takahiro HAYASHI
Hello, On 08/10/14 22:44, Ryo ONODERA wrote: Sadly, if my guess (1) was true, my MacBook Air' and Lenovo ThinkStation E32's USB 3.0 does not work. No device is detected. Do these xHCIs work on other OS? If yes, hardware seems good. -- t-hash

Overflow in ptyfs

2014-08-11 Thread Maxime Villard
Hi, four bytes may overflow in ptyfs_vfsops.c::ptyfs_mount(). mount(XX, XX, XX, data, data_len) The kernel will copyin data_len bytes of data into a kernel-allocated buffer. This kernel buffer and data_len will be given to the appropriate xx_mount() function, where xx is a fs. ptyfs_moun