Re: ddb: rename show arptab to show routes

2016-04-12 Thread Christos Zoulas
On Apr 13, 9:51am, ozak...@netbsd.org (Ryota Ozaki) wrote: -- Subject: Re: ddb: rename show arptab to show routes | On Tue, Apr 12, 2016 at 8:31 PM, Christos Zoulas wrote: | > In article , | > Ryota Ozaki wrote: | >>Hi, | >> | >>show arptab command of ddb is now inappropriate | >>because it a

Re: ddb: rename show arptab to show routes

2016-04-12 Thread Ryota Ozaki
On Tue, Apr 12, 2016 at 8:31 PM, Christos Zoulas wrote: > In article > , > Ryota Ozaki wrote: >>Hi, >> >>show arptab command of ddb is now inappropriate >>because it actually dumps routes but arp entries >>aren't routes anymore. Though, the feature is useful. >>So I'd like to remain it as renam

Re: ddb: rename show arptab to show routes

2016-04-12 Thread Christos Zoulas
In article , Ryota Ozaki wrote: >Hi, > >show arptab command of ddb is now inappropriate >because it actually dumps routes but arp entries >aren't routes anymore. Though, the feature is useful. >So I'd like to remain it as renamed to show routes >and move the code from if_arp.c to route.c. > >How

Remove meaningless RTF_UP check

2016-04-12 Thread Ryota Ozaki
Hi, There is a questionable code in ip_hresolv_output: http://nxr.netbsd.org/xref/src/sys/netinet/ip_output.c#230 As the comment says, checking RTF_UP and doing re-rtalloc1 is questionable. IIUC, it's meaningless because: - An obtained rtentry is ensured that it's always RTF_UP by rtcache, r

ddb: rename show arptab to show routes

2016-04-12 Thread Ryota Ozaki
Hi, show arptab command of ddb is now inappropriate because it actually dumps routes but arp entries aren't routes anymore. Though, the feature is useful. So I'd like to remain it as renamed to show routes and move the code from if_arp.c to route.c. How about the change? Comments? Here is a patc