Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Martin Husemann
On Wed, Jun 30, 2021 at 10:20:08AM +0930, Brett Lymn wrote: > So, does this mean its ok to commit what I proposed to prevent the panic > with a view to the drivers being fixed in the future? Yes, probably good to do that for know (and please file a PR and assign to me so I don't forget to add a KA

Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Brett Lymn
On Tue, Jun 29, 2021 at 02:36:35PM +0200, Martin Husemann wrote: > > It is already merge hell and all drivers do it completley different on > the branch - so I'd prefer not to touch all drivers in head. > OK, I won't bash on the drivers then. > Not calling it if NULL is fine (we could do that n

Audio volume setting: not working - sometimes?

2021-06-29 Thread Mouse
9.1, amd64. Audio hardware is [ 1.047133] hdaudio0 at pci0 dev 31 function 3: HD Audio Controller [ 1.047133] hdaudio0: interrupting at msi5 vec 0 [ 1.047133] hdafg0 at hdaudio0: vendor 10ec product 0269 [ 1.047133] hdafg0: DAC00 2ch: HP Out [Jack] [ 1.047133] hdafg0: DAC01 2c

Re: SCSI scanners

2021-06-29 Thread Julian Coleman
Hi, > If it's really the case that SANE works with these, then that seems ok. > (I actually have a UMAX scsi scsanner but haven't powered it on in > years.) The scanners that we support are also on the SANE project lists [*], although the driver is marked as unsupported. > I wonder though if thi

Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Martin Husemann
On Tue, Jun 29, 2021 at 09:57:27PM +0930, Brett Lymn wrote: > Is that going to be soon? I was thinking of doing a sweep of the usb network > drivers to fix > this. It is not affecting me at the moment because the driver for wireless I > am using at > the moment actually defines if_stop. It is a

Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Brett Lymn
On Tue, Jun 29, 2021 at 11:16:37AM +0200, Martin Husemann wrote: > On Tue, Jun 29, 2021 at 03:46:20PM +0930, Brett Lymn wrote: > > I turned up a fix I had put into my source tree a while back, I think at > > the time the wireless driver (urtwn IIRC) did not set an entry for > > if_stop. > > This i

Re: SCSI scanners

2021-06-29 Thread Greg Troxel
Julian Coleman writes: > Can we get rid of the SCSI scanner support as well? It only supports old > HP and Mustek scanners, and its functionality is superseded by SANE (which > sends the relevant SCSI commands from userland). If it's really the case that SANE works with these, then that seems

Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Greg Troxel
Martin Husemann writes: > On Tue, Jun 29, 2021 at 03:46:20PM +0930, Brett Lymn wrote: >> I turned up a fix I had put into my source tree a while back, I think at >> the time the wireless driver (urtwn IIRC) did not set an entry for >> if_stop. > > This is a driver bug, we should not work around

SCSI scanners (Was: uscanner)

2021-06-29 Thread Julian Coleman
Hi all, Can we get rid of the SCSI scanner support as well? It only supports old HP and Mustek scanners, and its functionality is superseded by SANE (which sends the relevant SCSI commands from userland). Regards, Julian

Re: protect pmf from network drivers that don't provide if_stop

2021-06-29 Thread Martin Husemann
On Tue, Jun 29, 2021 at 03:46:20PM +0930, Brett Lymn wrote: > I turned up a fix I had put into my source tree a while back, I think at > the time the wireless driver (urtwn IIRC) did not set an entry for > if_stop. This is a driver bug, we should not work around it but catch it early and fix it.

Re: vn_open, EDUPFD, EMOVEFD

2021-06-29 Thread Christos Zoulas
In article , David Holland wrote: > >* Does anyone know why dev/kloader.c calls namei and then vn_open on >the same path? I remember seeing this before and leaving it alone >because nobody I could find was sure what the deal was, but it's >unlikely to work as-is and increasingly likely to break o