> On Jul 13, 2022, at 12:02 PM, Jason Thorpe wrote:
>
>> On Jul 13, 2022, at 11:25 AM, Taylor R Campbell
>> wrote:
>>
>> Sorry, haven't had time yet to do a full review, but I spot at least
>> one problem that means this won't fly as is: kqueue_register and
>> kqueue_scan both call filter_tou
On Tue, Jul 12, 2022 at 09:57:20AM -0400, Mouse wrote:
> > a. Define the source-level API in a way that is detached from the
> >C language.
>
> This can be done, but only by attaching it to some other language
> instead. It doesn't even make sense to talk about an API without it
On Mon, Jul 11, 2022 at 08:45:09PM -0700, Jakob Stoklund Olesen wrote:
> I saw this project on the wiki, and it reminds me of a problem I have
> been trying to understand better:
> https://wiki.netbsd.org/projects/project/language-neutral-interfaces/
>
> [...] This means I have to think ab
On Wed, 13 Jul 2022, Taylor R Campbell wrote:
Generally looks reasonable to me, assuming it passes the atf tests,
but give hannken@ another few days to review it?
I can confirm that the specific test for 56713 now passes. I have
not done a complete test run.
++--
> On Jul 13, 2022, at 11:25 AM, Taylor R Campbell
> wrote:
>
> Sorry, haven't had time yet to do a full review, but I spot at least
> one problem that means this won't fly as is: kqueue_register and
> kqueue_scan both call filter_touch under a spin lock, but with your
> patch filter_touch now
Generally looks reasonable to me, assuming it passes the atf tests,
but give hannken@ another few days to review it?
Maybe instead of adding vnode_impl.h to vfs_vnops.c, we can put the
vn_knote_* in vfs_vnode.c or create a new file vfs_knote.c, to avoid
having tentacles of vnode guts creep back in
Sorry, haven't had time yet to do a full review, but I spot at least
one problem that means this won't fly as is: kqueue_register and
kqueue_scan both call filter_touch under a spin lock, but with your
patch filter_touch now takes an rwlock -- which is forbidden under a
spin lock (and it'll crash u
