Re: MP-safe /dev/console and /dev/constty

2022-10-01 Thread Mouse
> i really like this except for the if () do { ... } while (0); else > abuse portion. please rework that part. it looks easiest to push > into a separate function, perhaps. You don't say what you don't like about it. There are only two things I don't like about it, and one of them (indentation)

re: MP-safe /dev/console and /dev/constty

2022-10-01 Thread matthew green
i really like this except for the if () do { ... } while (0); else abuse portion. please rework that part. it looks easiest to push into a separate function, perhaps. thanks. .mrg.

MP-safe /dev/console and /dev/constty

2022-10-01 Thread Taylor R Campbell
The attached patch series makes /dev/console and /dev/constty MP-safe, with careful rules around constty access so it doesn't add contention or mutexes to the paths used by printf(9). This passes some manual testing in qemu with TIOCCONS on a viocon(4) device, but since this touches a very intimat