Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-07 Thread Michał Górny
On Thu, 2019-06-06 at 11:10 -0400, Christos Zoulas wrote: > On Jun 6, 4:43pm, mgo...@gentoo.org (=?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=) > wrote: > -- Subject: Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE > > > I presume you mean the one in ptrace_machdep_doreques

Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-06 Thread Christos Zoulas
In article <62b4f30a-f5ad-6e6c-1406-568e5d517...@gmx.com>, Kamil Rytarowski wrote: >-=-=-=-=-=- >-=-=-=-=-=- > >On 06.06.2019 17:10, Christos Zoulas wrote: >> It is better style to do avoid the extra checks and duplication so I would >> also fix the original :-). >> >> Having said all of that, I

Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-06 Thread Kamil Rytarowski
On 06.06.2019 17:10, Christos Zoulas wrote: > It is better style to do avoid the extra checks and duplication so I would > also fix the original :-). > > Having said all of that, I don't see any of those changes are "risky" or > creating issues for the -9 branch, so I don't see a reason to delay t

Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-06 Thread Christos Zoulas
On Jun 6, 4:43pm, mgo...@gentoo.org (=?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=) wrote: -- Subject: Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE | I presume you mean the one in ptrace_machdep_dorequest()? I suppose it | was there (the code is based on xmmregs in i386) to clearly scope

Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-06 Thread Michał Górny
On Wed, 2019-06-05 at 11:53 -0400, Christos Zoulas wrote: > On Jun 5, 5:08pm, mgo...@gentoo.org (=?UTF-8?q?Micha=C5=82=20G=C3=B3rny?=) > wrote: > -- Subject: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE > > > Introduce two new ptrace() requests: PT_GETXSTATE and PT_S

Re: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-05 Thread Christos Zoulas
On Jun 5, 5:08pm, mgo...@gentoo.org (=?UTF-8?q?Micha=C5=82=20G=C3=B3rny?=) wrote: -- Subject: [PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE | Introduce two new ptrace() requests: PT_GETXSTATE and PT_SETXSTATE, | that provide access to the extended (and extensible) set of FPU

[PATCH v2 2/2] Implement PT_GETXSTATE and PT_SETXSTATE

2019-06-05 Thread Michał Górny
Introduce two new ptrace() requests: PT_GETXSTATE and PT_SETXSTATE, that provide access to the extended (and extensible) set of FPU registers on amd64 and i386. At the moment, this covers AVX (YMM) and AVX-512 (ZMM, opmask) registers. It can be easily extended to cover further register types with