Re: modload_03.diff, was: Don't load kernel modules from the current directory

2011-08-05 Thread Christos Zoulas
In article , Iain Hibbert wrote: >On Fri, 5 Aug 2011, Marc Balmer wrote: > >> This is the third iteration of the patch to make kernel module loading >> more secure. The only change to the previous patch is that the code, >> when loading a module from /stand/... now checks that the module name >>

Re: modload_03.diff, was: Don't load kernel modules from the current directory

2011-08-05 Thread Marc Balmer
Am 05.08.11 09:27, schrieb Iain Hibbert: > On Fri, 5 Aug 2011, Marc Balmer wrote: > >> This is the third iteration of the patch to make kernel module loading >> more secure. The only change to the previous patch is that the code, >> when loading a module from /stand/... now checks that the module

Re: modload_03.diff, was: Don't load kernel modules from the current directory

2011-08-05 Thread John Nemeth
On Nov 20, 8:34pm, Iain Hibbert wrote: } On Fri, 5 Aug 2011, Marc Balmer wrote: } } > This is the third iteration of the patch to make kernel module loading } > more secure. The only change to the previous patch is that the code, } > when loading a module from /stand/... now checks that the modu

Re: modload_03.diff, was: Don't load kernel modules from the current directory

2011-08-05 Thread Iain Hibbert
On Fri, 5 Aug 2011, Marc Balmer wrote: > This is the third iteration of the patch to make kernel module loading > more secure. The only change to the previous patch is that the code, > when loading a module from /stand/... now checks that the module name > does not contain a path separator charac

modload_03.diff, was: Don't load kernel modules from the current directory

2011-08-04 Thread Marc Balmer
This is the third iteration of the patch to make kernel module loading more secure. The only change to the previous patch is that the code, when loading a module from /stand/... now checks that the module name does not contain a path separator character. modload still works, but must be availab

Re: Don't load kernel modules from the current directory, second diff

2011-08-04 Thread Marc Balmer
Am 04.08.11 13:37, schrieb John Nemeth: > On Dec 25, 7:20am, Marc Balmer wrote: > } Subject: Re: Don't load kernel modules from the current directory, second > } This is a multi-part message in MIME format. > } --030702090605080608070109 > } Content-Type: text/pla

Re: Don't load kernel modules from the current directory, second diff

2011-08-04 Thread John Nemeth
On Dec 25, 7:20am, Marc Balmer wrote: } Subject: Re: Don't load kernel modules from the current directory, second } This is a multi-part message in MIME format. } --030702090605080608070109 } Content-Type: text/plain; charset=ISO-8859-15 } Content-Transfer-Encoding: 7bit } } T

Re: Don't load kernel modules from the current directory, second diff

2011-08-04 Thread Marc Balmer
Am 04.08.11 12:49, schrieb Edgar Fuß: >> it must start with either '.' or '/' > Do you rather mean ``./'' or ``/''? Do you want to allow .module, > .modules/module or ../module? .module would indeed work from the CWD, but then it can not be used to "poison" and module in the system module area,

Re: Don't load kernel modules from the current directory, second diff

2011-08-04 Thread Edgar Fuß
> it must start with either '.' or '/' Do you rather mean ``./'' or ``/''? Do you want to allow .module, .modules/module or ../module?

Re: Don't load kernel modules from the current directory, second diff

2011-08-04 Thread Marc Balmer
Thanks to all that replied to my initial diff. This second version is better, it allows to load a module from the filesystem with either an absolute path starting with '/' or a relative path starting with '.'. So you can still load a module from the CWD using modload ./mymodule.kmod module_load_

Re: Don't load kernel modules from the current directory

2011-08-03 Thread Marc Balmer
Am 03.08.11 09:23, schrieb Alan Barrett: > On Wed, 03 Aug 2011, Marc Balmer wrote: >> modload looks for modules first in the current working directory, if >> not found there the system module area is searched (/stand/...). >> [...] >> >> The proposed and attached patch changes this in two ways: The

Re: Don't load kernel modules from the current directory

2011-08-03 Thread Alan Barrett
On Wed, 03 Aug 2011, Marc Balmer wrote: modload looks for modules first in the current working directory, if not found there the system module area is searched (/stand/...). [...] The proposed and attached patch changes this in two ways: The module loader never looks in '.' by always construc

re: Don't load kernel modules from the current directory

2011-08-02 Thread matthew green
i like the current method. it is how pretty much all other systems i'm familiar with work, too. .mrg.

Don't load kernel modules from the current directory

2011-08-02 Thread Marc Balmer
modload looks for modules first in the current working directory, if not found there the system module area is searched (/stand/...). otoh, we don't look in '.' when we load libraries in userspace programs, we even removed '.' from the Lua loader but when it comes to kernel code we happily accept