Le 26/06/2014 20:46, Christos Zoulas a écrit :
> On Jun 26, 4:30pm, m...@m00nbsd.net (Maxime Villard) wrote:
> -- Subject: Re: Fix netbsd32's getfh()
>
> | I guess it's ok now?
>
> Yes, that looks fine. But why:
> if (error != 0)
> instead of:
>
On Jun 26, 4:30pm, m...@m00nbsd.net (Maxime Villard) wrote:
-- Subject: Re: Fix netbsd32's getfh()
| I guess it's ok now?
Yes, that looks fine. But why:
if (error != 0)
instead of:
if (error)
I think that most code in the tree uses the second form.
christos
Le 26/06/2014 04:04, Christos Zoulas a écrit :
> On Jun 26, 11:30am, m...@eterna.com.au (matthew green) wrote:
> -- Subject: re: Fix netbsd32's getfh()
>
> |
> | Christos Zoulas writes:
> | > Well, let's not propagate the evil design! I is is one thing having:
&g
On Jun 26, 11:30am, m...@eterna.com.au (matthew green) wrote:
-- Subject: re: Fix netbsd32's getfh()
|
| Christos Zoulas writes:
| > Well, let's not propagate the evil design! I is is one thing having:
| >
| > void *p = malloc(n);
| > free(p);
| >
| > whe
Christos Zoulas writes:
> Well, let's not propagate the evil design! I is is one thing having:
>
> void *p = malloc(n);
> free(p);
>
> where you know p is going to be NULL when it fails and another having:
>
> foo *p;
> error = allocate_foo(&p);
> free_foo(p);
>
>
In article <53ab0471.4080...@m00nbsd.net>,
Maxime Villard wrote:
>>
>> That should probably be:
>>
>> return error;
>>
>> since vfs_composefh_alloc() failed, and we should not be calling
>> vfs_composefh_free().
>
>Yes, but no. Actually, vfs_composefh_free() handles NULL correctl
Le 25/06/2014 17:28, Christos Zoulas a écrit :
> In article <53aa91a3.1070...@m00nbsd.net>,
> Maxime Villard wrote:
>> Hi,
>> Here is a patch to sync netbsd32 with the native getfh() syscall. In addition
>> to making it consistent, it also:
>>
>> a) fixes the return value:
>> } else
In article <53aa91a3.1070...@m00nbsd.net>,
Maxime Villard wrote:
>Hi,
>Here is a patch to sync netbsd32 with the native getfh() syscall. In addition
>to making it consistent, it also:
>
>a) fixes the return value:
> } else if (error == E2BIG) {
> error = copyou
Hi,
Here is a patch to sync netbsd32 with the native getfh() syscall. In addition
to making it consistent, it also:
a) fixes the return value:
} else if (error == E2BIG) {
error = copyout(&sz, SCARG_P32(uap, fh_size),
sizeof(size_t));
}
h
