Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-28 Thread Jaromír Doleček
The fix was committed, with only minor changes (some comments, and fixed mishandling of error return value in ffs_indirtrunc(). Jaromir 2016-10-06 22:36 GMT+02:00 Jaromír Doleček : > I've incorporated the mutex fix, here is the final patch relative to > trunk. I'd like

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-06 Thread Taylor R Campbell
Date: Thu, 6 Oct 2016 22:36:48 +0200 From: Jaromír Doleček I've incorporated the mutex fix, here is the final patch relative to trunk. I'd like to commit this sometime next week. OK, thanks, I'll try to find time to review in the next couple days!

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-06 Thread Jaromír Doleček
I've incorporated the mutex fix, here is the final patch relative to trunk. I'd like to commit this sometime next week. Jaromir 2016-10-01 19:00 GMT+02:00 Taylor R Campbell : >Date: Sat, 1 Oct 2016 18:40:31 +0200 >From: Jaromír Dole ek

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-01 Thread David Holland
On Sat, Oct 01, 2016 at 05:00:10PM +, Taylor R Campbell wrote: > It's also suboptimal that we sleep while holding rwlocks for vnode > locks, since rw_enter is uninterruptable, so if a wait inside the > kernel hangs with a vnode lock held, anyone else trying to examine > that vnode will

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-01 Thread Taylor R Campbell
Date: Sat, 1 Oct 2016 18:40:31 +0200 From: Jaromír Dole ek > Thanks for taking a shot at this! But I think it needs a little more > time for review -- certainly I can't digest it in the 24 hours you're > giving. Sure. OK, thanks! I'll try to find

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-01 Thread Jaromír Doleček
> Thanks for taking a shot at this! But I think it needs a little more > time for review -- certainly I can't digest it in the 24 hours you're > giving. Sure. > From a quick glance at the patch, I see one bug immediately in > vfs_wapbl.c that must have been introduced in a recent change: >

Re: WAPBL fix for deallocation exhaustion + slow file removal

2016-10-01 Thread Taylor R Campbell
Date: Sat, 1 Oct 2016 16:19:33 +0200 From: =?UTF-8?B?SmFyb23DrXIgRG9sZcSNZWs=?= attached patch contains a fix to WAPBL deallocation structure exhaustion and panic (kern/47146), and avoids need to do slow partial truncates in loop, fixing kern/49175.

WAPBL fix for deallocation exhaustion + slow file removal

2016-10-01 Thread Jaromír Doleček
Hi, attached patch contains a fix to WAPBL deallocation structure exhaustion and panic (kern/47146), and avoids need to do slow partial truncates in loop, fixing kern/49175. Patch changes wapbl_register_deallocation() to fail with EAGAIN when we run into the limit, and change ffs_truncate() and