Re: dkwedge: checksum before swapping?

2023-05-08 Thread Mouse
>> But that comment clearly indicates that _someone_ thought it >> reasonable to checksum before swapping, so I can't help wondering >> what use case that's appropriate for. > It's a checksum over the 16bit words in native byte order. So when > you access the words in opposite byte order, you need

Re: dkwedge: checksum before swapping?

2023-05-07 Thread Michael van Elst
mo...@rodents-montreal.org (Mouse) writes: >But that comment clearly indicates that _someone_ thought it >reasonable to checksum before swapping, so I can't help wondering what >use case that's appropriate for. It's a checksum over the 16bit words in native byte order. So when you access the word

dkwedge: checksum before swapping?

2023-05-07 Thread Mouse
In sys/dev/dkwedge/dkwedge_bsdlabel.c, I find (and I see more or less the same code in 5.2 and what cvsweb.n.o shows me) static int validate_label(mbr_args_t *a, daddr_t label_sector, size_t label_offset) { ... /* * We have validated the partition count. Checksum