On Jul 28, 2012, at 5:51 PM, Edgar Fuß wrote:
>> try attached patch for NetBSD-5 or -6.
> Ah, thanks! I applied the first chunk (I already applied something
> equivalent to the second myself) and now it works on wedges.
>
> Can this be pulled up to 6, please?
Requested pullup to NetBSD-5 and N
On Jul 28, 2012, at 5:34 PM, Edgar Fuß wrote:
>> The `-c' flag just sets an (initialized) pointer to a function and has
>> nothing to do with setting fss.fss_flags.
> Not directly. But it moves memory.
>
>> Please ktrace without `-c'.
> I already did that a week ago and posted to tech-userlevel.
> try attached patch for NetBSD-5 or -6.
Ah, thanks! I applied the first chunk (I already applied something
equivalent to the second myself) and now it works on wedges.
Can this be pulled up to 6, please?
> The `-c' flag just sets an (initialized) pointer to a function and has
> nothing to do with setting fss.fss_flags.
Not directly. But it moves memory.
> Please ktrace without `-c'.
I already did that a week ago and posted to tech-userlevel.
You clearly see a difference in the ioctl argument.
On Jul 28, 2012, at 5:21 PM, Edgar Fuß wrote:
>> For me (on -current/i386) `fssconfig -c' works
> Since it's uninitialized memory, that may well be true.
The `-c' flag just sets an (initialized) pointer to a function and has
nothing to do with setting fss.fss_flags.
Please ktrace without `-c'.
> For me (on -current/i386) `fssconfig -c' works
Since it's uninitialized memory, that may well be true.
> what error do you get?
None. It fails silently (e.g. fssconfig -l says "not in use").
On Jul 28, 2012, at 1:08 AM, Edgar Fuß wrote:
> Now, additionally to fssconfig -c not working at all for me
> (it does work without "-c"), it now looks that it doesn't work
> on wedges:
> That's on 6.0_BETA2/amd64.
Should work on wedges for -current, try attached patch for NetBSD-5 or -6.
For m
> Shouldn't that "|=" be a "="?
Changing that makes fssconfig -c work for an fs on raid0 (disklabel).
But it still fails on raid1/dk* (gpt).
This code in fssconfig.c looks suspicious to me:
if ((xflag || istmp) && isreg)
fss.fss_flags |= FSS_UNLINK_ON_CREATE;
else
fss.fss_flags = 0;
Shouldn't that "|=" be a "="?
Now, additionally to fssconfig -c not working at all for me
(it does work without "-c"), it now looks that it doesn't work
on wedges:
fssconfig CALL open(0x7f7fdbb0,2,0)
fssconfig NAMI "/dev/rfss0"
fssconfig RET open 3
fssconfig CALL ioctl(3,FSSIOCSET,0x7f7fdbf0)
fssconfig GIO fd 3
10 matches
Mail list logo
