Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-24 Thread SAITOH Masanobu
On 2021/11/24 3:41, Christos Zoulas wrote: In article <87b00947-9e9a-f2c1-7c79-d3ba6e41a...@execsw.org>, SAITOH Masanobu wrote: Hi. On 2021/11/11 17:32, RVP wrote: On Wed, 10 Nov 2021, Ryota Ozaki wrote: Another option may be if_noproto.  ozaki-r On Wed, 10 Nov 2021, Havard Eidnes wro

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-22 Thread RVP
On Mon, 22 Nov 2021, SAITOH Masanobu wrote: I wrote a patch for better counting: Better counting for ierrors, iqdrops and noproto in ether_input(). - Use if_noproto for unknown or unsupported protocols. - Use if_ierror for wrong mbuf and oversized frame. Thank you for that. I'm

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-22 Thread SAITOH Masanobu
Hi. On 2021/11/11 17:32, RVP wrote: On Wed, 10 Nov 2021, Ryota Ozaki wrote: Another option may be if_noproto.  ozaki-r On Wed, 10 Nov 2021, Havard Eidnes wrote: which further supports the suggestion to use if_noproto for the stated condition. I'll use `if_noproto'. Should've done that

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-11 Thread RVP
On Wed, 10 Nov 2021, Ryota Ozaki wrote: Another option may be if_noproto. ozaki-r On Wed, 10 Nov 2021, Havard Eidnes wrote: which further supports the suggestion to use if_noproto for the stated condition. I'll use `if_noproto'. Should've done that from the start--missed the forest for

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-10 Thread Havard Eidnes
>> >OK, so discarded packets are fine as `if_iqdrops'. Otherwise, a kernel w/o >> >vlan (or netatalk, carp, ...) compiled in will show: >> >> Yes, I think that we need the distinction between discard and drop... >> Or we should just not count discard... > > Another option may be if_noproto. Exactl

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-09 Thread Ryota Ozaki
On Wed, Nov 10, 2021 at 6:03 AM Christos Zoulas wrote: > > In article <3360841c-e7fc-147d-1347-fe427d41a...@sdf.org>, > RVP wrote: > >On Mon, 8 Nov 2021, Jason Thorpe wrote: > > > >>> On Nov 7, 2021, at 11:07 PM, RVP wrote: > >>> > >>> So, I hacked up a small patch to put most of these into the

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-08 Thread RVP
On Mon, 8 Nov 2021, Jason Thorpe wrote: On Nov 7, 2021, at 11:07 PM, RVP wrote: So, I hacked up a small patch to put most of these into the "if_iqdrops" bucket. The rest (following FreeBSD) remain as errors. LGTM! On Mon, 8 Nov 2021, Christos Zoulas wrote: As far as I'm concerned, you c

Re: if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-08 Thread Jason Thorpe
> On Nov 7, 2021, at 11:07 PM, RVP wrote: > > So, I hacked up a small patch to put most of these into the > "if_iqdrops" bucket. The rest (following FreeBSD) remain as errors. LGTM! -- thorpej

if_ethersubr.c: if_ierrors -> if_iqdrops?

2021-11-07 Thread RVP
After noticing for some time now, an excessive no. of errors in my alc(4) card's stats, this weekend, I decided to find out what ailed it. But after poking around adding printf()s all over the shop and comparing against 9.2_STABLE, FreeBSD-13.0 and Linux 5.0.0, I figured out that there was nothing