Re: locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-02 Thread J. Hannken-Illjes
> On 2. Apr 2017, at 18:19, Taylor R Campbell > wrote: > >> Date: Sun, 2 Apr 2017 16:34:20 +0200 >> From: "J. Hannken-Illjes" >> >> Looks like your proposal needs some clarification regarding "vnode lock" >> and "the lock". >> >> We have two vnode related locks: >> >> - the "vnode lock", lo

Re: locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-02 Thread Taylor R Campbell
> Date: Sun, 2 Apr 2017 16:34:20 +0200 > From: "J. Hannken-Illjes" > > Looks like your proposal needs some clarification regarding "vnode lock" > and "the lock". > > We have two vnode related locks: > > - the "vnode lock", located as field "vi_lock" in "struct vnode_impl" > used by genfs_*loc

Re: locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-02 Thread J. Hannken-Illjes
> On 2. Apr 2017, at 16:05, Taylor R Campbell > wrote: > >> Date: Sun, 2 Apr 2017 10:47:42 +0200 >> From: "J. Hannken-Illjes" >> >>> On 1. Apr 2017, at 20:41, Taylor R Campbell >>> wrote: >>> VOP_RECLAIM then *destroys* the lock, so we don't have to say whether >>> it is held or released on

Re: locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-02 Thread Taylor R Campbell
> Date: Sun, 2 Apr 2017 10:47:42 +0200 > From: "J. Hannken-Illjes" > > > On 1. Apr 2017, at 20:41, Taylor R Campbell > > wrote: > > VOP_RECLAIM then *destroys* the lock, so we don't have to say whether > > it is held or released on exit. This requires a one-line change to > > vfs_vnode.c, and

Re: locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-02 Thread J. Hannken-Illjes
> On 1. Apr 2017, at 20:41, Taylor R Campbell > wrote: > > Currently: > > - For VOP_INACTIVE, vnode lock is held on entry and released on exit. > - For VOP_RECLAIM, vnode lock is not held on entry. > > I would like to change this so that: > > - For VOP_INACTIVE, vnode lock is held on entry a

locking from VOP_INACTIVE to VOP_RECLAIM

2017-04-01 Thread Taylor R Campbell
Currently: - For VOP_INACTIVE, vnode lock is held on entry and released on exit. - For VOP_RECLAIM, vnode lock is not held on entry. I would like to change this so that: - For VOP_INACTIVE, vnode lock is held on entry and exit. - For VOP_RECLAIM, vnode lock is held on entry. VOP_RECLAIM then *d