Re: Length of wmesg for condvar?

2010-08-09 Thread Paul Goyette
On Mon, 9 Aug 2010, Matthew Mondor wrote: On Mon, 9 Aug 2010 22:21:02 +0100 David Laight wrote: On Mon, Aug 09, 2010 at 02:02:51PM -0700, Paul Goyette wrote: Does anyone object to my going through and coming up with shorter names (<= 8 chars) for these condvars? It is worth chcking whethe

Re: Length of wmesg for condvar?

2010-08-09 Thread Matthew Mondor
On Mon, 9 Aug 2010 22:21:02 +0100 David Laight wrote: > On Mon, Aug 09, 2010 at 02:02:51PM -0700, Paul Goyette wrote: > > > > Does anyone object to my going through and coming up with shorter names > > (<= 8 chars) for these condvars? > > It is worth chcking whether they are displayed with a "

re: Length of wmesg for condvar?

2010-08-09 Thread matthew green
> On Mon, Aug 09, 2010 at 02:38:32AM -0400, Matthew Mondor wrote: > > On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) > > Paul Goyette wrote: > > > > > Should these be changed? Are there any adverse effects from having a > > > wmesg longer than 8 characters? > > > > It seems to me that the exporter o

Re: Length of wmesg for condvar?

2010-08-09 Thread David Laight
On Mon, Aug 09, 2010 at 02:02:51PM -0700, Paul Goyette wrote: > > Does anyone object to my going through and coming up with shorter names > (<= 8 chars) for these condvars? It is worth chcking whether they are displayed with a "%.8s" format (or similar) so that they don't need to be 0 terminated

Re: Length of wmesg for condvar?

2010-08-09 Thread Paul Goyette
On Mon, 9 Aug 2010, Matthew Mondor wrote: On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette wrote: Should these be changed? Are there any adverse effects from having a wmesg longer than 8 characters? It seems to me that the exporter of those use strncpy() (i.e. kern/init_sysctl.c) and t

Re: Length of wmesg for condvar?

2010-08-09 Thread David Laight
On Mon, Aug 09, 2010 at 02:38:32AM -0400, Matthew Mondor wrote: > On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) > Paul Goyette wrote: > > > Should these be changed? Are there any adverse effects from having a > > wmesg longer than 8 characters? > > It seems to me that the exporter of those use strnc

Re: Length of wmesg for condvar?

2010-08-08 Thread Matthew Mondor
On Sun, 8 Aug 2010 17:23:23 -0700 (PDT) Paul Goyette wrote: > Should these be changed? Are there any adverse effects from having a > wmesg longer than 8 characters? It seems to me that the exporter of those use strncpy() (i.e. kern/init_sysctl.c) and that the structures use WMESGLEN and KI_WME