Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Michael van Elst
On Sat, Sep 16, 2023 at 08:57:28PM +1000, Simon Burge wrote: > The only corner case that an older kernel won't understand a longer root > device name passed in by a newer /boot as the old kernel will still have > the 16 char length limit. Yes, old kernels will truncate the name. Since that's

Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Simon Burge
Martin Husemann wrote: > On Sat, Sep 16, 2023 at 06:51:40AM -, Michael van Elst wrote: > > > There is one caveat. Since all x86 bootloader data is funneled through > > the bootinfo structure we have: > > > > struct btinfo_rootdevice { > > struct btinfo_common common; > >

Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Manuel Bouyer
On Sat, Sep 16, 2023 at 08:17:16AM +0200, Martin Husemann wrote: > [...] > But the more general solution (which would be just as easy for the end > user, but more flexibel) is to add support for a rootdev statement > in boot.cfg and then put the label name or the guid there. Similar > to evbarm

Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Martin Husemann
On Sat, Sep 16, 2023 at 06:51:40AM -, Michael van Elst wrote: > You can already specify the root in boot.cfg. OK, the man page needs an update. > >It would also be cool if boot.cfg could specify the partition to load > >the kernel from via something similiar to NAME=. > > You can already

Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Michael van Elst
mar...@duskware.de (Martin Husemann) writes: >But the more general solution (which would be just as easy for the end >user, but more flexibel) is to add support for a rootdev statement >in boot.cfg and then put the label name or the guid there. Similar >to evbarm taking a root=dev argument passed

Re: GPT attributes in dkwedge [PATCH]

2023-09-16 Thread Martin Husemann
On Sat, Sep 16, 2023 at 05:01:00AM +, Emmanuel Dreyfus wrote: > The patch moves the GPT parser out of dkwedge so that it can > be used by other kernel componentx. You calll gpt_walk() with > a callback invoked for each GPT entry. dkwedge use it to do the > job it was doing before, and