Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-23 Thread Olivier Crête
On Mon, 2008-10-20 at 12:20 +0100, Dafydd Harries wrote: > If the config file thing is changed, I'm happy with the branch. I've created > a telepathy-farsight repository for you to merge to. Ok, the proper branch is now the master of this new repository. I also have proposed branches of libtp-fs

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-20 Thread Dafydd Harries
Ar 17/10/2008 am 14:58, ysgrifennodd Olivier Crête: > On Fri, 2008-10-17 at 17:54 +0100, Dafydd Harries wrote: > > Ar 14/10/2008 am 16:25, ysgrifennodd Olivier Crête: > > > On Fri, 2008-10-10 at 16:06 +0100, Dafydd Harries wrote: > > > > +confdir = $(sysconfdir)/xdg/stream-engine > > > > > > > >

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-17 Thread Olivier Crête
On Fri, 2008-10-17 at 17:54 +0100, Dafydd Harries wrote: > Ar 14/10/2008 am 16:25, ysgrifennodd Olivier Crête: > > On Fri, 2008-10-10 at 16:06 +0100, Dafydd Harries wrote: > > > -service_in_files = org.freedesktop.Telepathy.StreamEngine.service.in > > > +service_in_files = org.maemo.Telepathy.Strea

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-17 Thread Dafydd Harries
Ar 14/10/2008 am 16:25, ysgrifennodd Olivier Crête: > First, thanks for the review. I fixed most of the problems that you > found. > > Extra questions/comments follow: > > On Fri, 2008-10-10 at 16:06 +0100, Dafydd Harries wrote: > > -service_in_files = org.freedesktop.Telepathy.StreamEngine.servi

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-15 Thread mikhail.zabaluev
: Re: [Telepathy] review: stream engine 'fs2-lib' branch > >> >> -service_in_files = >org.freedesktop.Telepathy.StreamEngine.service.in >> >> +service_in_files = org.maemo.Telepathy.StreamEngine.service.in >> >> >> >> Hmm, this seems li

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-15 Thread Olivier Crête
dd Harries > >Cc: Telepathy > >Subject: Re: [Telepathy] review: stream engine 'fs2-lib' branch > > > >On Fri, 2008-10-10 at 16:06 +0100, Dafydd Harries wrote: > >> -service_in_files = org.freedesktop.Telepathy.StreamEngine.service.in > >> +service_in_file

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-15 Thread mikhail.zabaluev
Hi, >-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On Behalf Of >ext Olivier Crête >Sent: Tuesday, October 14, 2008 11:25 PM >To: Dafydd Harries >Cc: Telepathy >Subject: Re: [Telepathy] review: stream engine 'fs2-lib' branch &g

Re: [Telepathy] review: stream engine 'fs2-lib' branch

2008-10-14 Thread Olivier Crête
First, thanks for the review. I fixed most of the problems that you found. Extra questions/comments follow: On Fri, 2008-10-10 at 16:06 +0100, Dafydd Harries wrote: > -service_in_files = org.freedesktop.Telepathy.StreamEngine.service.in > +service_in_files = org.maemo.Telepathy.StreamEngine.servi

[Telepathy] review: stream engine 'fs2-lib' branch

2008-10-10 Thread Dafydd Harries
+ +»···Called to tell Stream Engine to Attach itself to a channel. + Remove this tab. doc/Makefile \ +»··· doc/lib/Makefile \ + telepathy-farsight/Makefile \ +»··· telepathy-farsight/telepathy-farsight.pc \ src/Makefile \ Remove these t