Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-20 Thread Ben Cotton
I generally agree with Adam's points. We don't want to add tests for every accepted Change proposal. In particular, the "updating X to version Y". That said, I think we should be checking for certain paradigm-shift or otherwise notable changes. Changes to the default filesystem, moving to Wayland b

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-20 Thread Chris Murphy
On Sat, Dec 18, 2021, 1:17 PM Matthew Miller wrote: > > But it does seem like we should have _some_ set of automated testing that's > linked to intentional, acccepted changes. Nano-as-default in Fedora Server > is another one. > Yeah, nano also vanished from Server edition in the 35 cycle. Once

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-18 Thread Adam Williamson
On Sat, 2021-12-18 at 15:16 -0500, Matthew Miller wrote: > On Sat, Dec 18, 2021 at 10:49:53AM -0800, Adam Williamson wrote: > > > This makes sense to me. It might also make sense for big changes to also > > > include proposed updates to the validation criteria, just as modern > > > software > > >

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-18 Thread Matthew Miller
On Sat, Dec 18, 2021 at 10:49:53AM -0800, Adam Williamson wrote: > > This makes sense to me. It might also make sense for big changes to also > > include proposed updates to the validation criteria, just as modern software > > development expects new features to come with tests for those features.

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-18 Thread Adam Williamson
On Sat, 2021-12-18 at 13:23 -0500, Matthew Miller wrote: > On Sat, Dec 18, 2021 at 09:09:17AM -0800, Adam Williamson wrote: > > However, I think there'd be a solid case for FESCo to take anything > > like this as a blocker, and procedurally that makes more sense too - > > Changes are under FESCo's

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-18 Thread Matthew Miller
On Sat, Dec 18, 2021 at 09:09:17AM -0800, Adam Williamson wrote: > However, I think there'd be a solid case for FESCo to take anything > like this as a blocker, and procedurally that makes more sense too - > Changes are under FESCo's remit. So if a case like this is caught > before release, I'd say

Re: is an accidentally reverted Fedora feature/change a blocker?

2021-12-18 Thread Adam Williamson
On Fri, 2021-12-17 at 19:29 -0700, Chris Murphy wrote: > Fedora 33 brough systemd-resolved by default; but in Fedora 35 this > somehow got reverted. > > I've proposed it as a blocker, but the main point of the thread is > really to discuss the general case of whether such a thing is a > blocker? I

is an accidentally reverted Fedora feature/change a blocker?

2021-12-17 Thread Chris Murphy
Fedora 33 brough systemd-resolved by default; but in Fedora 35 this somehow got reverted. I've proposed it as a blocker, but the main point of the thread is really to discuss the general case of whether such a thing is a blocker? I'm not thinking of a release criterion that applies to this case. I