;
and then the code will look like:
my $skip_reason = missing foo;
if ($skip_reason) {
skip $skip_reason, 3;
}
else {
# do something
ok 1;
ok 1;
ok 1;
}
let us know if that's needed.
_
Stas Bekman JAm_pH
Doug MacEachern wrote:
On Thu, 8 Nov 2001, Stas Bekman wrote:
patch doesn't apply for me, but looks good so just commit and ..
done
+my @reasons = ();
for (@modules) {
+my $reason;
if (/^[a-z0-9_]+$/) {
not sure if your mail has munged the patch, but indentation looks
}
that's according to Test::Harness manpage. May be you have different
versions?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto
);
-plan tests = @pods + keys(%other_files), sub { $perlpod };
+plan tests = @pods + keys(%other_files),
+sub { $perlpod ? 1 : dir $vars-{perlpod} doesn't exist};
my $location = /getfiles-perl-pod;
_
Stas Bekman JAm_pH
.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http
and then will do all these things.
I also plan to change t_cmp to trace only if there is a mismatch, or
it's run under a special debug mode. Otherwise big tests generate too
much clutter.
_
Stas Bekman JAm_pH
be:
ok t_cmp(($goodbad eq 'fail' ? 400 : 200),
GET_RC(/, %fields),
Testing LimitRequestFields; should $goodbad
);
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org
1..0\n.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http
=! 1 and WIN32 and we can solve
it later.
Or does it mean that the tests that require 1+ servers need to skip on
WIN32?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide
/$_.shtml;
-chomp $actual;
+$actual =~ s/[\r\n]+$//s;
print $_: EXPECT -$expected- ACTUAL -$actual-\n;
return $actual eq $expected;
};
--
_
Stas Bekman JAm_pH
.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
methods in this module?
Or is it ok, since it's not exported?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED
Rodent of Unusual Size wrote:
Stas Bekman wrote:
Which means that we should gradually change all the tests
to start the comments with '#', or they may break in the future.
Does that include things like the debug: messages in expires.t?
Or are such immune or don't count?
Anything that you print
On Wed, 17 Oct 2001, Doug MacEachern wrote:
On Wed, 17 Oct 2001, Stas Bekman wrote:
t/TEST -proxy t/foo/bar.t
...
I see exactly the same behavior with my patch and without, so I guess it
was broken before.
yup, i already told you the same in private email. but see the commit
message
if $@;
+return {0 = missing $_} if $@;
}
-return 1;
+return {1 = undef};
}
sub have_cgi {
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http
Doug MacEachern wrote:
On Thu, 18 Oct 2001, Stas Bekman wrote:
is there anything else we need to do with opts parsing at this stage?
now that we know all args and which are meant as test files, anything else
should throw an error. for example what ken saw:
% t/TEST t/notexist
currently ignores
available on the
web and link to them from httpd.apache.org/test/
If you have something to contribute to the existing doc, please go ahead
-- it still needs a lot of work.
Thanks Geoff!
_
Stas Bekman JAm_pH
to point it there.
So yes, you have to add a few 'lib' pragmas, but that's normal. You have
to do it in any Perl code that uses modules that aren't located in the
standard location.
I'm glad you've solved this problem.
_
Stas
.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http
the module first!!
Yup, you got it right. I'll fix the docs.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http
clayton cottingham wrote:
Stas Bekman wrote:
563PREOP = 'pod2text lib/Apache/Amazing.pm README', should it
bePREOP = `pod2text lib/Apache/Amazing.pm README`,
{back ticked?}
nope
wierd it only works backticked for me
strange?
what's the point of PREOP than? May be your version
Doug MacEachern wrote:
i don't feel strongly enough either way to debate further. i'll leave the
decision to you stas.
neither do I, so I'm just leaving the way it's ($class, $self).
_
Stas Bekman JAm_pH
that APACHE_TEST_* subs will be all
functions and not OO methods, therefore I think that passing $module is
just confusing.
But if you think it may be of use in the future, sure let's keep it that
way.
_
Stas Bekman
/Bar.pm
hope that answers your question
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http
project. The source can be
seen here:
http://cvs.apache.org/viewcvs.cgi/modperl-docs/src/devel/writing_tests/writing_tests.pod
thanks.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org
On Sat, 8 Sep 2001, Doug MacEachern wrote:
On Sat, 8 Sep 2001, Stas Bekman wrote:
all autogenerated files should be cleaned.
true.
+my @clean_conf = map { t/conf/$_ }
+qw(*.conf apache_test_config.pm ssl/ssl.conf);
but we should really hook into calling 't/TEST -clean'
via
On Wed, 5 Sep 2001, Doug MacEachern wrote:
On Sun, 2 Sep 2001, Stas Bekman wrote:
I was thinking about creating two bundles: Bundle::ApacheTestMin (to
include the absolute minimum required to run basic tests) and
Bundle::ApacheTestMax to include everything that's needed to run all
On Wed, 5 Sep 2001, Doug MacEachern wrote:
On Sun, 2 Sep 2001, Stas Bekman wrote:
this works for me. I had to exit on reconfiguration, since otherwise it'd
fail to continue. Should I reconfigure in a different way, so I won't have
to exit?
great. you can use refresh() to reconfigure
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com http://perl.apache.org http
. =-) -- justin
I've just screwed up with stray -m tag :( must go and eat something... I
am reverting it now :(
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http
up?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http
, portability issue. How about:
$ENV{PATH} = ''; We use full paths anyway.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL
the perlsec manpage:
% perldoc perlsec
or as the mod_perl guide suggests:
http://perl.apache.org/guide/help.html#Get_help_with_Perl_CGI:
http://www.gunther.web66.com/FAQS/taintmode.html
_
Stas Bekman JAm_pH
/to/httpd-and-apxs:$PATH
so I was ruining it. So would the empty path will be OK?
local $ENV{PATH} = '';
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http
$actual = GET_BODY $cgi_uri, Host = $_;
chomp $actual;
ok t_cmp_str($cgi_string $_,
$actual,
VirtualScriptAlias test
);
}
_
Stas Bekman JAm_pH -- Just
On Fri, 31 Aug 2001, Doug MacEachern wrote:
On Fri, 31 Aug 2001, Stas Bekman wrote:
When you cvs update, make sure to run './t/TEST -clean'. I've noticed that
one of the subtests in alias.t was failing. It was because extra.conf.in
has been changed, but the stale autogenerated extra.conf
for the test writers for free.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://localhost/ http
or
not, to cause less errors and questions?
sorry Doug :)
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http
;
}
-rmdir htdocs/modules/vhost_alias;
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://localhost/ http
written. Some variables weren't initialized and used while
undef.
which tests do you have this problem with? please report to the test-dev
list, so their respective owners can fix these.
Thanks.
_
Stas Bekman JAm_pH
};
$thaw-{vars}-{$key} = $self-{vars}-{$key};
$changed = 1;
}
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto
of map would be of immense value for people who
join the tests project, and useful for the current contributors as the
number of tests grow.
Thank you.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http
On Wed, Aug 08, 2001 at 10:28:24AM +0800, Stas Bekman wrote:
+
+ OK, so why not to do: /^[1-6]$/ ?
this wouldnt test for the right thing.
+ I'd do it even more flexible:
+
+ my $pat = join '', @num;
+ /^[$pat]$/
+
+ so now you can change @num and not to worry about forgetting adjusting
:)
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http://apachetoday.com http://eXtropia.com/
http://singlesheaven.com
How do I get to see cvs commits for test-dev?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:[EMAIL PROTECTED] http
operation if not, rather then report failure.
In addition during the skip, you can print a note, how to add the missing
feature.
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org
On Tue, 7 Aug 2001, john sachs wrote:
it is a range.
so according to the error:
Invalid [] range -6 before HERE mark in regex
what kind of range -6 is?
On Tue, Aug 07, 2001 at 02:13:35PM +0800, Stas Bekman wrote:
+ perl t/TEST httpd /home/stas/httpd-2.0/bin/httpd -run t/modules/rewrite.t
601 - 647 of 647 matches
Mail list logo
