Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
David Wheeler wrote: On Friday, July 11, 2003, at 09:27 AM, Sander Temme wrote: The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? Yes, th

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread David Wheeler
On Friday, July 11, 2003, at 09:27 AM, Sander Temme wrote: The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? Yes, the redirect_ok subrouti

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Sander Temme
on 7/11/03 9:06, David Wheeler at [EMAIL PROTECTED] wrote: > The above patch doesn't work. But this does: Ehm... works for me. I think you're working in the mod_perl space and I'm just concentrating on the Apache core. Maybe there are side effects that I'm not seeing? > --- TestRequest.pm.~1.8

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread David Wheeler
On Friday, July 11, 2003, at 02:22 AM, Stas Bekman wrote: diff -u -r1.81 TestRequest.pm --- Apache-Test/lib/Apache/TestRequest.pm 8 Jul 2003 07:56:24 - 1.81 +++ Apache-Test/lib/Apache/TestRequest.pm 11 Jul 2003 04:28:45 - @@ -88,14 +88,12 @@ $UA = undef; } -

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
Sander Temme wrote: on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote: Does this work? else if ($redir) { $RedirectOK = $redir; } It does. However, isn't this the same condition as in the top if clause? Wouldn't you want to: Index: Apache-Test/lib/Apache/TestRequest.pm ==

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Sander Temme
on 7/10/03 18:00, Stas Bekman at [EMAIL PROTECTED] wrote: > > Does this work? > > else if ($redir) { >$RedirectOK = $redir; > } It does. However, isn't this the same condition as in the top if clause? Wouldn't you want to: Index: Apache-Test/lib/Apache/TestRequest.pm ==

Re: [PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-11 Thread Stas Bekman
Sander Temme wrote: on 7/10/03 12:56, Sander Temme at [EMAIL PROTECTED] wrote: parameter to the request invocations in t/apache/acceptpathinfo.t. Neither produces any result. Am I looking in the right place? Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by liberally sprinklin

[PATCH] Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestRequest.pm

2003-07-10 Thread Sander Temme
on 7/10/03 12:56, Sander Temme at [EMAIL PROTECTED] wrote: > parameter to the request invocations in t/apache/acceptpathinfo.t. Neither > produces any result. Am I looking in the right place? Breadcrumbing my way through Apache-Test/lib/Apache/TestRequest.pm by liberally sprinkling print statemen