Re: Apache-Test and Cwd

2004-01-31 Thread Stas Bekman
David, I've committed the required changed. Please test that it works for you. I still have a few other things to fix (t/SMOKE), but they shouldn't affect you. __ Stas BekmanJAm_pH -- Just Another mod_perl Hacker

Re: Apache-Test and Cwd

2004-01-31 Thread David Wheeler
On Jan 30, 2004, at 5:18 PM, Stas Bekman wrote: David, I've committed the required changed. Please test that it works for you. I still have a few other things to fix (t/SMOKE), but they shouldn't affect you. Yep, works great for me. Thanks! David

Re: Apache-Test and Cwd

2004-01-30 Thread Stas Bekman
I forgot that we already have the vars() shortcut, I have added a query mode to it, so now you can do: my $serverroot = Apache::Test::vars-{serverroot}; my $serverroot = Apache::Test::vars('serverroot'); my($top_dir, $t_dir) = Apache::Test::vars(qw(top_dir t_dir)); that's almost as good as

Re: Apache-Test and Cwd

2004-01-29 Thread Geoffrey Young
Stas Bekman wrote: David Wheeler wrote: On Jan 28, 2004, at 2:21 PM, Stas Bekman wrote: Then for now I'll just use: my $serverroot = Apache::Test::config()-{vars}{serverroot}; the idea is to get away from that - it's way too verbose to be conventient. AUTOLOAD is okay with me. It's

Re: Apache-Test and Cwd

2004-01-28 Thread Geoffrey Young
Stas Bekman wrote: David Wheeler wrote: On Jan 23, 2004, at 12:21 PM, Stas Bekman wrote: If you really want to, we could install Apache::Test::AUTOLOAD which will map $AUTOLOAD to Apache::Test::config()-{vars}-{$AUTOLOAD}, so you could say: Apache::Test::serverroot Or, I imagine,

Re: Apache-Test and Cwd

2004-01-28 Thread David Wheeler
On Jan 28, 2004, at 2:21 PM, Stas Bekman wrote: Then for now I'll just use: my $serverroot = Apache::Test::config()-{vars}{serverroot}; Surely you mean my $serverroot = Apache::Test::config()-{vars}-{serverroot}; although this should work, too: my $serverroot =

Re: Apache-Test and Cwd

2004-01-28 Thread Stas Bekman
David Wheeler wrote: On Jan 28, 2004, at 2:21 PM, Stas Bekman wrote: Then for now I'll just use: my $serverroot = Apache::Test::config()-{vars}{serverroot}; Surely you mean my $serverroot = Apache::Test::config()-{vars}-{serverroot}; although this should work, too: my $serverroot =

Re: Apache-Test and Cwd

2004-01-23 Thread Geoffrey Young
I'll wait for a blessing from Geoff and then try to fix the mp2 and httpd-test/perl-framework tests first. If successful, then it'll be in the next release. yes, lots of breakage there. I think what I'd like to see is an easier way to get the ServerRoot (and DocumentRoot?) than

Re: Apache-Test and Cwd

2004-01-23 Thread David Wheeler
On Jan 23, 2004, at 8:27 AM, Geoffrey Young wrote: it's not that I don't agree this ought to be fixed, or that with the patch we have desirable behavior, it's just that I want it to be easy and the current ServerRoot placement isn't really easy or intuitive. maybe Apache::Test could export a

Re: Apache-Test and Cwd

2004-01-23 Thread David Wheeler
On Jan 23, 2004, at 12:21 PM, Stas Bekman wrote: If you really want to, we could install Apache::Test::AUTOLOAD which will map $AUTOLOAD to Apache::Test::config()-{vars}-{$AUTOLOAD}, so you could say: Apache::Test::serverroot Or, I imagine, Apache::Test-serverroot That's kind of cool. David

Re: Apache-Test and Cwd

2004-01-23 Thread Stas Bekman
David Wheeler wrote: On Jan 23, 2004, at 12:21 PM, Stas Bekman wrote: If you really want to, we could install Apache::Test::AUTOLOAD which will map $AUTOLOAD to Apache::Test::config()-{vars}-{$AUTOLOAD}, so you could say: Apache::Test::serverroot Or, I imagine, Apache::Test-serverroot Yes,

Apache-Test and Cwd

2004-01-21 Thread David Wheeler
Hi All, A while ago, I enquired about the Cwd that Apache::Test uses, and asked if something could be added to make it different. This is because a lot of existing test modules (such as Test::POD) expect tests to be run from the distribution package root. Apache::Test is fairly unique (outside

Re: Apache-Test and Cwd

2004-01-21 Thread Stas Bekman
David Wheeler wrote: Hi All, A while ago, I enquired about the Cwd that Apache::Test uses, and asked if something could be added to make it different. This is because a lot of existing test modules (such as Test::POD) expect tests to be run from the distribution package root. Apache::Test

Re: Apache-Test and Cwd

2004-01-21 Thread David Wheeler
On Jan 20, 2004, at 11:20 PM, Stas Bekman wrote: Does the patch below solve the problem? Maybe, but it's not quite there yet: Can't locate object method chdir_t via package Apache::TestHarness at lib/Apache/TestRun.pm line 648. Not yet. It should be trivial for someone who knows Module::Build,

Re: Apache-Test and Cwd

2004-01-21 Thread Stas Bekman
David Wheeler wrote: On Jan 20, 2004, at 11:20 PM, Stas Bekman wrote: Does the patch below solve the problem? Maybe, but it's not quite there yet: Can't locate object method chdir_t via package Apache::TestHarness at lib/Apache/TestRun.pm line 648. Sorry, David, I guess I was testing with the

Re: Apache-Test and Cwd

2004-01-21 Thread David Wheeler
On Jan 21, 2004, at 12:39 PM, Stas Bekman wrote: Sorry, David, I guess I was testing with the wrong version. Here is a new patch. It breaks quite a few tests in modperl-2.0 but it's because they rely on that chdir_t, and can be fixed to be relocatable. It's possible that there are other

Re: Apache-Test and Cwd

2004-01-21 Thread David Wheeler
On Jan 21, 2004, at 1:11 PM, Stas Bekman wrote: It just doesn't do any chdirs, so you can really run: /foo/bar/tar/mar/t/TEST and it will run from / Cool, I suspect that that's more or less how Test::Harness works, too -- it just runs the test from whatever Cwd you're in when you call

Re: Apache-Test and Cwd

2004-01-21 Thread Stas Bekman
David Wheeler wrote: And of course all tests that rely on the previous behavior need to be fixed too. There quite a few tests to fix in mp2, I haven't tested other repositories, yet. It's a nice, straight-forward patch, so my guess is that the tests would be fairly easy to fix, yes? I think,

Re: Apache-Test and Cwd

2004-01-21 Thread David Wheeler
On Jan 21, 2004, at 2:00 PM, Stas Bekman wrote: I think, yes. It's actually a goodness to make tests relocatable, in case someone moves things around. Nice. I'll wait for a blessing from Geoff and then try to fix the mp2 and httpd-test/perl-framework tests first. If successful, then it'll be in