Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigC.pm

2004-03-07 Thread Stas Bekman
Rodent of Unusual Size wrote: Stas Bekman wrote: Well dversion is generated by A-T and it's -D APACHE$self-{rev}, why taking chances and match partial strings? What assumptions are you talking about, when both live inside the same package. And it seems to be awkward at all, since what you are

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigC.pm

2004-03-06 Thread Stas Bekman
[EMAIL PROTECTED] wrote: coar2004/03/05 08:54:19 Modified:perl-framework/Apache-Test/lib/Apache TestConfigC.pm Log: too many assumptions that things will stay the same -if ($dversion eq '-DAPACHE1') { +if ($dversion =~ 'APACHE1') { Well dversion is generated by A-T

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigC.pm

2004-03-05 Thread Geoffrey Young
+my $dversion = $self-server-dversion; +if ($dversion eq '-DAPACHE1') { that's '-D APACHE1' in current cvs, no? --Geoff

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigC.pm

2004-03-05 Thread Rodent of Unusual Size
Geoffrey Young wrote: +my $dversion = $self-server-dversion; +if ($dversion eq '-DAPACHE1') { that's '-D APACHE1' in current cvs, no? so i saw, when my tests blew up. -- #kenP-)} Ken Coar, Sanagendamgagwedweinini http://Ken.Coar.Org/ Author, developer, opinionist