Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2004-04-28 Thread Stas Bekman
Geoffrey Young wrote: I don't understand why did you have this problem (what did you have in @INC?), but I think that this just works around the problem. It's better to go up to where $self->{inc} is getting set and not let invalid values in, so if you use $self->{inc} you won't have to workaround

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2004-04-28 Thread Geoffrey Young
> I don't understand why did you have this problem (what did you have in > @INC?), but I think that this just works around the problem. It's better > to go up to where $self->{inc} is getting set and not let invalid values > in, so if you use $self->{inc} you won't have to workaround again. I was

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2004-04-28 Thread Stas Bekman
[EMAIL PROTECTED] wrote: geoff 2004/04/28 07:55:42 Modified:perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm Log: prevent 'Empty compile time value given to use lib' warnings Revision ChangesPath 1.88 +1 -0 httpd-test/perl-framework/Apache-Test/lib/Apach

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2002-12-04 Thread Stas Bekman
Geoffrey Young wrote: this change is causing problems for me: *** setting ulimit to allow core files ulimit -c unlimited; t/TEST !!! configure() has failed: Use of uninitialized value in numeric gt (>) at /src/bleedperl/lib/site_perl/5.9.0/i686-linux-thread-multi/Apache/TestConfig Perl.pm line 288

RE: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2002-12-03 Thread Geoffrey Young
this change is causing problems for me: *** setting ulimit to allow core files ulimit -c unlimited; t/TEST !!! configure() has failed: Use of uninitialized value in numeric gt (>) at /src/bleedperl/lib/site_perl/5.9.0/i686-linux-thread-multi/Apache/TestConfig Perl.pm line 288, line 65. both und

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-18 Thread Stas Bekman
Doug MacEachern wrote: i don't feel strongly enough either way to debate further. i'll leave the decision to you stas. neither do I, so I'm just leaving the way it's ($class, $self). _ Stas Bekman JAm_pH -- Just

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-17 Thread Doug MacEachern
i don't feel strongly enough either way to debate further. i'll leave the decision to you stas.

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-17 Thread Stas Bekman
Doug MacEachern wrote: On Sun, 16 Sep 2001, Stas wrote: and what's the user of $class? When you can access it via __PACKAGE__ and you don't really need it anyway. __PACKAGE__ is not helpful if one day a test .pm wants to inherit APACHE_TEST_CONFIGURE from another class. most of the Apache::Te

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-16 Thread Doug MacEachern
On Sun, 16 Sep 2001, Stas wrote: > and what's the user of $class? When you can access it via __PACKAGE__ > and you don't really need it anyway. __PACKAGE__ is not helpful if one day a test .pm wants to inherit APACHE_TEST_CONFIGURE from another class. most of the Apache::Test* is OO, so i am t

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-16 Thread Stas
Doug MacEachern wrote: On Sun, 16 Sep 2001, Stas wrote: Hmm, we don't want to pass the package name to the package itself why not? because we know the package name anyway inside that package. :) this fixes it, so we can write: sub APACHE_TEST_CONFIG { my $self = shift; this seems fine t

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-15 Thread Doug MacEachern
On Sun, 16 Sep 2001, Stas wrote: > Hmm, we don't want to pass the package name to the package itself why not? > this fixes it, so we can write: > > sub APACHE_TEST_CONFIG { > my $self = shift; this seems fine to me: my($class, $config) = @_; > -eval { $module->APACHE_

Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm

2001-09-15 Thread Stas
[EMAIL PROTECTED] wrote: dougm 01/09/15 12:29:30 Modified:perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm Log: APACHE_TEST_CONFIGURE needs the Apache::TestConfig object Hmm, we don't want to pass the package name to the package itself, this fixes it, so we can write: sub