Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread David Wheeler
On Oct 19, 2004, at 2:48 PM, Stas Bekman wrote: In which case, can you please review Boris' patch and commit it if you think it's good? As I haven't coded and haven't used much this feature, I'd rather let somebody who is more familiar with it do the decision. If it breaks something, we can

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread Stas Bekman
David Wheeler wrote: On Oct 19, 2004, at 2:48 PM, Stas Bekman wrote: In which case, can you please review Boris' patch and commit it if you think it's good? As I haven't coded and haven't used much this feature, I'd rather let somebody who is more familiar with it do the decision. If it breaks

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread David Wheeler
On Oct 19, 2004, at 6:26 PM, Stas Bekman wrote: that looks better than goto :) Yeah... But this means that POST redirects will work if LWP is installed and won't if it is not. If it's true that, without LWP, TestRequest *cannot* handle redirect on POST requests, then this is how it should be. I