Re: Fix: Apache::TestRequest::redirect_ok

2004-10-22 Thread Stas Bekman
David Wheeler wrote: On Oct 19, 2004, at 11:23 PM, David Wheeler wrote: But please wait before mp2/Apache-Test are released tomorrow, since were are in the code freeze section as both have RC posted, and in theory no code should be committed (docs are OK). Will do. Committed. that was quick :)

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread David Wheeler
On Oct 19, 2004, at 2:48 PM, Stas Bekman wrote: In which case, can you please review Boris' patch and commit it if you think it's good? As I haven't coded and haven't used much this feature, I'd rather let somebody who is more familiar with it do the decision. If it breaks something, we can

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread Stas Bekman
David Wheeler wrote: On Oct 19, 2004, at 2:48 PM, Stas Bekman wrote: In which case, can you please review Boris' patch and commit it if you think it's good? As I haven't coded and haven't used much this feature, I'd rather let somebody who is more familiar with it do the decision. If it breaks

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-20 Thread David Wheeler
On Oct 19, 2004, at 6:26 PM, Stas Bekman wrote: that looks better than goto :) Yeah... But this means that POST redirects will work if LWP is installed and won't if it is not. If it's true that, without LWP, TestRequest *cannot* handle redirect on POST requests, then this is how it should be. I

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Boris Zentner
Hi, Am Dienstag 19 Oktober 2004 01:12 schrieb Stas Bekman: Boris Zentner wrote: [...] Older ones use ( $self, $request ) newer use ( $self, $request, $response); This routine forward the redirect_ok call to the underlying class(LWP::UserAgent, but maybe not always) if possible else,

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread David Wheeler
On Oct 18, 2004, at 4:52 PM, Boris Zentner wrote: No, in that case I return $RedirectOK. I think that at least the return 0 if $request-method eq 'POST'; line is wrong, since I clearly have no chance to redirect a post request. I just left it that way because that the way it was when I started

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Stas Bekman
David Wheeler wrote: On Oct 18, 2004, at 4:52 PM, Boris Zentner wrote: No, in that case I return $RedirectOK. I think that at least the return 0 if $request-method eq 'POST'; line is wrong, since I clearly have no chance to redirect a post request. I just left it that way because that the way

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread David Wheeler
On Oct 19, 2004, at 5:22 AM, Stas Bekman wrote: Is it because you can't really do redirects on real POST requests? The body will get lost, isn't it? No, we do them all the time in Bricolage. Regards, David

Re: Fix: Apache::TestRequest::redirect_ok

2004-10-19 Thread Stas Bekman
David Wheeler wrote: On Oct 19, 2004, at 5:22 AM, Stas Bekman wrote: Is it because you can't really do redirects on real POST requests? The body will get lost, isn't it? No, we do them all the time in Bricolage. In which case, can you please review Boris' patch and commit it if you think it's

Fix: Apache::TestRequest::redirect_ok

2004-10-18 Thread Boris Zentner
Hi, on a older server, with perl 5.6.1 call Apache::TestRequest::redirect_ok and return 0 for POST requests, even if I overwrite this behavior with Apache::TestRequest::user_agent( reset = 1, cookie_jar = $cookie_jar,