Re: switching t_cmp() argument order

2004-06-10 Thread Stas Bekman
Geoffrey Young wrote: But it's quite possible that argument could be readonly while not a string, a simple example is a return value of a function: % perl -le 'a(b(), b); sub a {($_[0], $_[1]) = ($_[1], $_[0]);}; \ sub b { 5 }' Modification of a read-only value attempted at -e line 1.

Re: switching t_cmp() argument order

2004-06-10 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Geoffrey Young wrote: But it's quite possible that argument could be readonly while not a string, a simple example is a return value of a function: % perl -le 'a(b(), b); sub a {($_[0], $_[1]) = ($_[1], $_[0]);}; \ sub b { 5 }' Modification of a

Re: switching t_cmp() argument order

2004-06-10 Thread Stas Bekman
Geoffrey Young wrote: just add a line like, remove after Sep 15th or so. and may be take it into if ($deprecated) { ...} so it's easy to remove the whole branch at once without thinking too much. the logic was already wrapped in an if block, so I just made a note that we want it removed by mid

Re: switching t_cmp() argument order

2004-06-08 Thread James G Smith
Geoffrey Young [EMAIL PROTECTED] wrote: hi all before it gets too late I would like to change t_cmp() to t_cmp($received, $expected, $comment); so that test writers can feel at home in either environment. for the most part the change would be transparent to users as long as their tests pass.