Ack ... I was hitting the old SVN repository (since that's what comes up
when you search for "thrift svn" on Google).
My patch is arguably slightly better, but the current head is good
enough for our purposes, thanks.
Dave Engberg wrote:
I don't feel qualified to comment on the first par
And... apparently we do.
-Original Message-
From: David Reiss [mailto:[EMAIL PROTECTED]
Sent: Thursday, September 11, 2008 2:24 PM
To: thrift-dev@incubator.apache.org
Subject: Re: Patch: add https support to PHP THttpClient
Am I just crazy, or don't we already have this feature?
I don't feel qualified to comment on the first part of your email, but
I'm looking at the trunk head, and that still seems to hard-code in
'http://' :
http://svn.facebook.com/svnroot/thrift/trunk/lib/php/src/transport/THttpClient.php
I think my patch might be slightly cleaner, since it allows
h to
> it here:
> http://issues.apache.org/jira/browse/THRIFT
>
> Cheers,
> Mark
>
>
> -Original Message-
> From: David Engberg [mailto:[EMAIL PROTECTED]
> Sent: Thursday, September 11, 2008 2:05 PM
> To: thrift-dev@incubator.apache.org
> Subject: Patch
: thrift-dev@incubator.apache.org
Subject: Patch: add https support to PHP THttpClient
The trunk PHP library doesn't support HTTPS transport via
THttpClient.php. I've attached a relatively small change to this class
that adds an optional fourth constructor parameter ('protocol'
The trunk PHP library doesn't support HTTPS transport via
THttpClient.php. I've attached a relatively small change to this class
that adds an optional fourth constructor parameter ('protocol') which
can be used to specify 'http' or 'https'.
Usage:
$transport = new THttpClient('www.evern
