Ack ... I was hitting the old SVN repository (since that's what comes up
when you search for "thrift svn" on Google).
My patch is arguably slightly better, but the current head is good
enough for our purposes, thanks.
Dave Engberg wrote:
I don't feel qualified to comment on the first par
And... apparently we do.
-Original Message-
From: David Reiss [mailto:[EMAIL PROTECTED]
Sent: Thursday, September 11, 2008 2:24 PM
To: thrift-dev@incubator.apache.org
Subject: Re: Patch: add https support to PHP THttpClient
Am I just crazy, or don't we already have this feature?
I don't feel qualified to comment on the first part of your email, but
I'm looking at the trunk head, and that still seems to hard-code in
'http://' :
http://svn.facebook.com/svnroot/thrift/trunk/lib/php/src/transport/THttpClient.php
I think my patch might be slightly cleaner, since it allows
Am I just crazy, or don't we already have this feature?
http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=2c6b42c63c0e757e6b855409804543c059fbbc9b
Mark Slee wrote:
> Thanks Dave, this looks fine to me.
>
> The official process is to create a JIRA ticket and attach the patch to
> it here:
Thanks Dave, this looks fine to me.
The official process is to create a JIRA ticket and attach the patch to
it here:
http://issues.apache.org/jira/browse/THRIFT
Cheers,
Mark
-Original Message-
From: David Engberg [mailto:[EMAIL PROTECTED]
Sent: Thursday, September 11, 2008 2:05 PM
To:
