Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-31 Thread Peter Åstrand
On Tue, 30 Aug 2011, DRC wrote: On 8/30/11 5:33 AM, Pierre Ossman wrote: You seem to be providing good stuff, so I'd vote for you getting commit rights. Adam? DRC? Any objections? No objections here-- just standard rules for everyone: before committing any potentially disruptive new features

[Tigervnc-devel] [PATCH] Multithreaded ComparingUpdateTracker

2011-08-31 Thread Robert King
I was working on a project for school that included implementing a multithreaded version of the ComparingUpdateTracker class to try and improve overall performance. There are a couple things I was unsure about. I'm not sure how the THREADED flag should be set as well as the THREADPOOL_SIZE constant

Re: [Tigervnc-devel] [PATCH] Multithreaded ComparingUpdateTracker

2011-08-31 Thread DRC
Have you done any research to validate the usefulness of the ComparingUpdateTracker? Personally, I found that, in Xvnc, it wasn't catching very many duplicate updates, and the dupes it was catching would not have significantly slowed down performance (they tended to be areas of solid color, whi

Re: [Tigervnc-devel] [PATCH] Support more menu keys

2011-08-31 Thread Martin Koegler
On Wed, Aug 31, 2011 at 10:15:34AM +0200, Peter ?strand wrote: > On Tue, 30 Aug 2011, DRC wrote: > > >On 8/30/11 5:33 AM, Pierre Ossman wrote: > >>You seem to be providing good stuff, so I'd vote for you getting > >>commit rights. Adam? DRC? Any objections? > > > >No objections here-- just standar