Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-18 Thread Adam Tkac
On Thu, Nov 11, 2010 at 10:51:46PM +0100, Martin Koegler wrote: > Two general comments: Thanks for your comments, I've modified the patch and commited it as r4198. > * This patch will probably break the windows build, as it adds an > msg!=NULL assert without setting the variable on Windows. The b

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-11 Thread Martin Koegler
Two general comments: * This patch will probably break the windows build, as it adds an msg!=NULL assert without setting the variable on Windows. The best solution would be to add the windows implementation too. * CSecurityTLS is only available, if tigervnc is built with GNUTLS. So it should brea

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-11 Thread Guillaume Destuynder
On 11/10/2010 10:24 PM, Martin Koegler wrote: > The best thing would be to change the default value of cafile at the > startup of the program to $HOME/ . The current implementation only > allows fixed values as default. I hit a similar problem while there > was only one security type parameter

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-10 Thread Martin Koegler
On Wed, Nov 10, 2010 at 01:24:35PM +0100, Guillaume Destuynder wrote: > No difference for me, I did as recommended on the IRC channel. I can put > it directly there, too. If there's already a patch for this however I > don't mind if it's used instead, in fact, it would be great too. My implementio

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-11-10 Thread Guillaume Destuynder
On 10/27/2010 11:15 PM, Martin Koegler wrote: 1) > On Wed, Oct 27, 2010 at 02:36:46PM +0200, Guillaume Destuynder wrote: > Basic question: Wouldn't a generic messagebox (like in > http://e9925248.users.sourceforge.net/0005-client-side-TLS-tunnel.patch > File common/rfb/UserMsgBox.h) be more usefu

Re: [Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-10-27 Thread Martin Koegler
On Wed, Oct 27, 2010 at 02:36:46PM +0200, Guillaume Destuynder wrote: > Index: unix/vncviewer/CConn.cxx > === > --- unix/vncviewer/CConn.cxx (revision 4175) > +++ unix/vncviewer/CConn.cxx (working copy) > +// getCertificateReply() is

[Tigervnc-devel] [PATCH] Dialogs for certificates (Unix client only)

2010-10-27 Thread Guillaume Destuynder
Hi, The attached patches show a dialog to accept the X509 certificate if it's not yet trusted. For example, if you haven't specified a certificate and it's the first time you connect to a X509 enabled TigerVNC server. Consequently, this also work for self-signed certificates. It adds 2 files from