Re: [tipc-discussion] [PATCH] TIPC: fix tipc_link_create error handling

2007-07-23 Thread Stephens, Allan
Hi Florian: Changes look pretty good to me. I'd also recommend deferring the call to k_init_timer() to the same point as your list_add_tail() call. (If you don't, then there should really be a k_term_timer() call in the clean up code that handles a failure of tipc_node_attach_link().) Regards,

[tipc-discussion] [PATCH] TIPC: fix tipc_link_create error handling

2007-07-23 Thread Florian Westphal
if printbuf allocation or tipc_node_attach_link() fails, invalid references to the link are left in the associated node and bearer structures. Fix by doing printbuf allocation early and adding the new link to b_ptr->links after tipc_node_attach_link() succeeded. Signed-off-by: Florian Westphal <[E

Re: [tipc-discussion] OpenSAF: A software suite that uses TIPC

2007-07-23 Thread Marella P-G19460
Jon, My thoughts are inline below prefixed by [PHANI], Rgds, Phani > -Original Message- > From: Jon Paul Maloy [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 18, 2007 6:51 PM > To: Marella P-G19460 > Cc: tipc-discussion@lists.sourceforge.net; Betham R-G19443; > Vishal Soni-G20083; Redd

[tipc-discussion] REMINDER - TIPC Working Group Meeting on Thursday

2007-07-23 Thread Stephens, Allan
The next meeting of the TIPC Working Group is scheduled for Thursday, July 26th, 2007 at 11 AM EDT. (Please convert to your local time zone.) PROPOSED AGENDA: Brainstorming on approaches to provide control/data plane separation in a TIPC network. (Several companies have expressed interest in see